Kibana app migration: Centralize home dependencies #48618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins, test this. Failure looks unrelated |
Contributor
💚 Build Succeeded |
flash1293
added
Feature:NP Migration
and removed
Feature:Home
flash1293
added
the
release_note:skip
kertal
approved these changes
Oct 23, 2019
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM 👍 Tested locally in Chrome.
| trackUiMetric: createUiStatsReporter('Kibana_home'), | ||
| METRIC_TYPE, | ||
|
|
||
| toastNotifications, |
Member
There was a problem hiding this comment.
You could use npStart.core.notifications.toasts now or in a future iteration
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 25, 2019
flash1293
added a commit
that referenced
this pull request
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all imports of other plugins into a central file to prepare for shimming the plugin.
Installing the shim and getting rid of the local angular router will be done in a separate PR.