Skip to content

Fixed default color on dashboard load #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2013
Merged

Fixed default color on dashboard load #486

merged 1 commit into from
Sep 17, 2013

Conversation

@bobrik
Copy link

@bobrik bobrik commented Sep 12, 2013

Now it works as expected :)

@rottenbytes
Copy link

rottenbytes commented Sep 14, 2013

upvote 👍

@bobrik
Copy link
Author

bobrik commented Sep 15, 2013

I updated it to match latest master

@mwildehahn
Copy link

mwildehahn commented Sep 16, 2013

👍

@rashidkpc
Copy link
Contributor

rashidkpc commented Sep 16, 2013

Please take a look at https://github.com/rashidkpc/kibana3/blob/master/CONTRIBUTING.md and let me know when you've completed all of the steps, then I can go ahead and merge this

@bobrik
Copy link
Author

bobrik commented Sep 16, 2013

Yep, all done. Grunt said Done, without errors.

@bobrik
Copy link
Author

bobrik commented Sep 16, 2013

Also, maybe second point in CONTRIBUTING.md should be explained with npm install && grunt.

@Seldaek
Copy link

Seldaek commented Sep 17, 2013

Am I correct in thinking this fixes the reloading of previous query colors from a saved dashboard? It drives me mad that it loses my nice error/warning/ok colors for graphs every time I reload :)

@bobrik
Copy link
Author

bobrik commented Sep 17, 2013

@Seldaek you are right :)

@Seldaek
Copy link

Seldaek commented Sep 17, 2013

OK awesome then, looking forward to seeing this merged.

@rashidkpc
Copy link
Contributor

rashidkpc commented Sep 17, 2013

@bobrik Have you signed the CLA? I don't see your name on the list yet.

@bobrik
Copy link
Author

bobrik commented Sep 17, 2013

Sorry about that. I just did it and got confirmation to my email.

@rashidkpc rashidkpc merged commit fc069a0 into elastic:master Sep 17, 2013
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
Merge pull request elastic#486 from matt/add-esdatalogmessage-remove-…
d0b8a50 
…godeps-mod

US16065 Add esdatalogmessage remove godeps mod
@larrycameron80 larrycameron80 mentioned this pull request Jan 10, 2023
Open
edmarmoretti pushed a commit to edmarmoretti/kibana-pt-br that referenced this pull request Sep 7, 2025
@markov00
feat(partition): add legend and highlighters (elastic#616)
6a4247e 
This commit adds the legend and highlighters to partition charts.
Two new options are added to the <Settings/> components: `flatLegend` will flat the legend for pie/tree hierarchical legend and `legendMaxDepth` will limit the legend hierarchy to a maximum depth value: 1 is the root level (can be combined with the `flatLegend`).

close elastic#486, close elastic#532
edmarmoretti pushed a commit to edmarmoretti/kibana-pt-br that referenced this pull request Sep 7, 2025
@semantic-release-bot
chore(release): 18.3.0 [skip ci]
1e3a130 
# [18.3.0](elastic/elastic-charts@v18.2.2...v18.3.0) (2020-04-15)

### Bug Fixes

* remove series with undefined splitSeriesAccessor values ([elastic#627](elastic/elastic-charts#627)) ([59f0f6e](elastic/elastic-charts@59f0f6e))

### Features

* gauge, goal and bullet graph (alpha) ([elastic#614](elastic/elastic-charts#614)) ([5669178](elastic/elastic-charts@5669178))
* **partition:** add legend and highlighters ([elastic#616](elastic/elastic-charts#616)) ([6a4247e](elastic/elastic-charts@6a4247e)), closes [elastic#486](elastic/elastic-charts#486) [elastic#532](elastic/elastic-charts#532)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobrik @rottenbytes @mwildehahn @rashidkpc @Seldaek