Skip to content

[Task Manager] Fixes error when we claim new tasks beyond capacity#48384

Merged
gmmorris merged 2 commits intoelastic:masterfrom
gmmorris:task-manager/fix-zero-available-workers
Oct 16, 2019
Merged

[Task Manager] Fixes error when we claim new tasks beyond capacity#48384
gmmorris merged 2 commits intoelastic:masterfrom
gmmorris:task-manager/fix-zero-available-workers

Conversation

@gmmorris
Copy link
Contributor

Fixed issue where we would try and claim new tasks even when there are no available workers

Summary

An error was introduced recently when Task Manager tries to claim tasks despite having no available workers to do so, resulting in an invalid updateByQuery being submitted on every pool refresh interval, flooding the logs.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@gmmorris gmmorris requested a review from a team October 16, 2019 09:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

Copy link
Contributor

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Haven't pulled the PR locally

@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gmmorris gmmorris merged commit 323d71e into elastic:master Oct 16, 2019
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 16, 2019
…lastic#48384)

Fixes an issue where we would try and claim new tasks even when there are no available workers
gmmorris added a commit that referenced this pull request Oct 16, 2019
…48384) (#48399)

Fixes an issue where we would try and claim new tasks even when there are no available workers
@gmmorris gmmorris deleted the task-manager/fix-zero-available-workers branch November 21, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants