[Task Manager] Fixes error when we claim new tasks beyond capacity#48384
Merged
gmmorris merged 2 commits intoelastic:masterfrom Oct 16, 2019
Merged
Conversation
… even when there are no available workers
Contributor
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
Bamieh
approved these changes
Oct 16, 2019
Contributor
Bamieh
left a comment
There was a problem hiding this comment.
Code LGTM. Haven't pulled the PR locally
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 16, 2019
…lastic#48384) Fixes an issue where we would try and claim new tasks even when there are no available workers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue where we would try and claim new tasks even when there are no available workers
Summary
An error was introduced recently when Task Manager tries to claim tasks despite having no available workers to do so, resulting in an invalid
updateByQuerybeing submitted on every pool refresh interval, flooding the logs.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers