[ML] Removing old angular directives#48382
Conversation
jgowdyelastic
added
review
chore
non-issue
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
walterra
|
Pinging @elastic/ml-ui (:ml) |
| <EuiSpacer size="m" /> | ||
| <EuiCallOut | ||
| title={i18n.translate('xpack.ml.accessDenied.label', { | ||
| defaultMessage: 'You need permission to access ML jobs', |
There was a problem hiding this comment.
Compared to the previous angular version, the texts here don't mention the user roles anymore. However, the text is still specific about ML jobs, which could be irrelevant if a user doesn't have permissions to even access file visualizer. Maybe the messaging should be even more generic for this PR until we can come up with something more elaborate in combination with react-router?
There was a problem hiding this comment.
good point. i've updated the text.
It's worth noting that currently this page will not be redirected to automatically. So unless someone navigates to it directly in their browser, no one will see it.
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
One text edit need to the Callout, but otherwise LGTM
| <EuiSpacer size="m" /> | ||
| <EuiCallOut | ||
| title={i18n.translate('xpack.ml.accessDenied.label', { | ||
| defaultMessage: 'You need permission to the Ml plugin', |
There was a problem hiding this comment.
Should be ML rather than Ml to be consistent with message below.
Also title doesn't quite make sense - You need permission to use the ML plugin or maybe Insufficient permissions ?
💔 Build Failed |
💚 Build Succeeded |
* [ML] Removing old angular directives * reverts small change * typescriptifying access denied page * changing access denied text * updating translations
* [ML] Removing old angular directives * reverts small change * typescriptifying access denied page * changing access denied text * updating translations
5 participants
Removes unused angular directives from components which have been reactified.
Adjusts some component exports and import paths.
This converts the access denied page to react but this avoids any other reactification or typescriptification which would be out of scope for this PR.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately