[Lens] Add date histogram interval to column name#48271
Merged
chrisdavies merged 10 commits intoelastic:masterfrom Oct 16, 2019
Merged
[Lens] Add date histogram interval to column name#48271chrisdavies merged 10 commits intoelastic:masterfrom
chrisdavies merged 10 commits intoelastic:masterfrom
Conversation
chrisdavies
added
v8.0.0
release_note:skip
wylieconlon
approved these changes
Oct 15, 2019
Contributor
wylieconlon
left a comment
wylieconlon
left a comment
There was a problem hiding this comment.
This change LGTM. Tested in app and dashboard.
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
wylieconlon
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
wylieconlon
reviewed
Oct 16, 2019
|
|
||
| return `${expression} | ${filterRatios | ||
| .map(([id]) => `lens_calculate_filter_ratio id=${id}`) | ||
| .join(' | ')}`; |
Contributor
There was a problem hiding this comment.
This filter ratio part is no longer needed
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a date histogram is selected, we now will display the
per whatever intervalsuffix that esaggs assigns: