[SIEM] update ip/hosts details tables to zero when detailName changes#48253
Merged
stephmilovic merged 6 commits intoelastic:masterfrom Oct 16, 2019
Merged
[SIEM] update ip/hosts details tables to zero when detailName changes#48253stephmilovic merged 6 commits intoelastic:masterfrom
stephmilovic merged 6 commits intoelastic:masterfrom
Conversation
stephmilovic
changed the title
stephmilovic
added
release_note:skip
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
patrykkopycinski
approved these changes
Oct 15, 2019
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
spong
pushed a commit
to spong/kibana
that referenced
this pull request
Oct 16, 2019
spong
added a commit
that referenced
this pull request
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the call to
setIpDetailsTablesActivePageToZerofrom NFlowTable to the top level IP Details page. Creates a new action that handles the same behavior on the Hosts Details page,setHostDetailsTablesActivePageToZero. These reset Resets all IP/Hosts Details tables to zero when thedetailName(IP or Host) changes.To test:
On an IP Details page with multiple pages of results for the Source N Flow Table, select a page other than page 1 for the Source N Flow Table. Click into a different IP with multiple pages of results for the Source N Flow Table. The page should get reset to page 1.
On an Hosts Details page with multiple pages of results for the Authentications Table, select a page other than page 1 for the Authentications Table. Click into a different IP with multiple pages of results for the Authentications Table. The page should get reset to page 1.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately