[Sample Data] Add event.dataset to sample web logs#48150
Merged
Zacqary merged 3 commits intoelastic:masterfrom Oct 15, 2019
Merged
[Sample Data] Add event.dataset to sample web logs#48150Zacqary merged 3 commits intoelastic:masterfrom
Zacqary merged 3 commits intoelastic:masterfrom
Conversation
Zacqary
added
release_note:fix
v8.0.0
Feature:Logs UI
Contributor
|
Pinging @elastic/infra-logs-ui (Team:infra-logs-ui) |
Contributor
💚 Build Succeeded |
simianhacker
requested changes
Oct 14, 2019
Member
simianhacker
left a comment
simianhacker
left a comment
There was a problem hiding this comment.
The index pattern in src/legacy/server/sample_data/data_sets/logs/saved_objects.js needs to be updated with the event.dataset field. The best way to go about that is to load the sample data set, go to the Kibana index pattern, and refresh the index pattern. Then go to the Saved Object UI, under management, and export just the index pattern. You should be able to copy the contents from the JSON file and update the index pattern.
Contributor
💚 Build Succeeded |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Oct 15, 2019
* [Sample Data] Add event.dataset to sample web logs * Update saved_objects.js
Zacqary
added a commit
that referenced
this pull request
Oct 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #47119
Adds an
event.datasetproperty to the sample web logs.Checklist
[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials-
[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers