Fix saved query in app state in discvoer

[flash1293]

Fixes #46363

This bug got introduced in 0656e4f because it truthy-checks $scope.savedQuery before loading a query which never gets populated because it references a $route.current.locals.savedQuery that never gets resolved (line 223) - this line seems like a leftover to me.

The fix in this PR solves the problem by fixing the condition when loading the query and making sure the search on initial page load is not triggered if a saved query is referenced because it will be loaded async and trigger a search itself.

There is another option to implement this - it would also be possible to resolve the query like index pattern and saved search are resolved as part of the resolve prop of the route specification. I didn't chose that way because it relies on the angular way of doing things and might be more difficult to clean up later on - I expect this controller will be broken down and migrated away from angular in the near future anyway. Maybe there is a good reason to follow through with the initial implementation approach, happy to change this.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: 84e4e1e

[TinaHeiligers]

@flash1293 this fix works, thanks for that. As for the approach, I'm not sure if relying on Angular's way of doing things is better because, as you mention, it might make clean up later difficult.

[flash1293]

Jenkins, test this.

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 84e4e1e

[TinaHeiligers]

Tested in Chrome and it works as expected.
Code looks fine.
LGTM!

[Bargs]

Fix looks good!

We have the same code in visualize and dashboard, do you mind updating those as well?

kibana/src/legacy/core_plugins/kibana/public/visualize/editor/editor.js

Line 550 in 22e6d3d

if ($scope.savedQuery && newSavedQueryId !== $scope.savedQuery.id) {

kibana/src/legacy/core_plugins/kibana/public/dashboard/dashboard_app_controller.tsx

Line 500 in 0d7dfba

if ($scope.savedQuery && newSavedQueryId !== $scope.savedQuery.id) {

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 7f9fcb0

[Bargs]

LGTM