Expressions np #47810
Merged
Expressions np #47810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
Feature:ExpressionLanguage
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
streamich
added
the
release_note:skip
Contributor
💔 Build Failed |
ppisljar
reviewed
Oct 16, 2019
ppisljar
reviewed
Oct 16, 2019
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
timductive
added
review
Team:Presentation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
crob611
approved these changes
Oct 23, 2019
Contributor
crob611
left a comment
crob611
left a comment
There was a problem hiding this comment.
Canvas changes look good 👍
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
This was referenced Oct 30, 2019
streamich
added a commit
that referenced
this pull request
Oct 31, 2019
* refactor: 💡 generalize service getters and setters in expressio * feat: 🎸 create NP-ready plugin for expressions * refactor: 💡 flatten expressions plugin and remove service * chore: 🤖 re-export legacy expressions service dir for Lens * refactor: 💡 don't import renderer registry statically * test: 💍 mock expressions service renderers registry in Mocha * refactor: 💡 clean-up NP expressions pugin * refactor: 💡 move Expression fonts to NP * refactor: 💡 register Interpreter entities explicitly * refactor: 💡 move clog Expression function to NP * refactor: 💡 move font function and style types to NP * refactor: 💡 remove ui/chrome from kibana_context function * feat: 🎸 add ability to consume start core from setup life-cycle * refactor: 💡 move kibana_context function to NP * feat: 🎸 improve naming and delete import of missing function * refactor: 💡 register expression clog and font fn in NP * chore: 🤖 set AppArch as GitHub folder owners * refactor: 💡 move Expression "kibana" function to NP * refactor: 💡 move range function to visualizations plugin * feat: 🎸 move visDimensions to visualizations plugin * chore: 🤖 delete unused files * refactor: 💡 move expression type registration to NP * refactor: 💡 move createHandlers() function to NP * feat: 🎸 move Expression executor to NP * refactor: 💡 re-implement function registry * refactor: 💡 convert expression type to class * fix: 🐛 correct TypeScript errors * feat: 🎸 convert Expressions type registry to class * feat: 🎸 convert render function registry to class * fix: 🐛 fix TypeScript errors * fix: 🐛 fix translations after refactor * refactor: 💡 move Expression types to NP * test: 💍 remove unused test * fix: 🐛 fix Lens import after merge with master * fix: 🐛 fix TypeScript errors * refactor: 💡 update expression types * test: 💍 fix renderer test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38611, #44309