-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Look up axis format from series instead of using default formatter #47696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
flash1293
merged 4 commits into
elastic:master
from
flash1293:flash1293/13051-multi-y-formatters
Oct 14, 2019
Merged
Look up axis format from series instead of using default formatter #47696
flash1293
merged 4 commits into
elastic:master
from
flash1293:flash1293/13051-multi-y-formatters
Oct 14, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
ppisljar
approved these changes
Oct 14, 2019
Contributor
ppisljar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 14, 2019
flash1293
added a commit
that referenced
this pull request
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:XYAxis
XY-Axis charts (bar, area, line)
release_note:fix
Team:Visualizations
Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #13051
When building the axis config, this PR makes sure to use the format of the first series mapped to an axis instead of the default y axis formatter.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [] This includes a feature addition or change that requires a release note and was labeled appropriately