[Mappings editor] Integrate inside Template UI#47567
Merged
sebelga merged 4 commits intoelastic:feature/mappings-editorfrom Oct 8, 2019
Merged
Conversation
Contributor
💔 Build Failed |
jloleysens
approved these changes
Oct 8, 2019
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
@sebelga Thanks for this Seb. I think I should be able to work with this!
sebelga
added
Feature:Index Management
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
Author
|
Thanks @jloleysens ! I just pushed a few commits to make the integration work and it seems to hold pretty well 😊 Will merge this so you can create a branch out of it. |
7 tasks
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the mappings editor inside Template UI and adds an initial Json editor component.
Note The integration is not perfect yet but this PR will unblock @jloleysens for his work on the Json Editor.