Improve wording of save modal and listing page#47443
Merged
flash1293 merged 2 commits intoelastic:masterfrom Oct 10, 2019
Merged
Improve wording of save modal and listing page#47443flash1293 merged 2 commits intoelastic:masterfrom
flash1293 merged 2 commits intoelastic:masterfrom
Conversation
flash1293
added
Feature:kibana-react
Team:AppArch
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
flash1293
added
the
release_note:skip
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 10, 2019
flash1293
added a commit
that referenced
this pull request
Oct 10, 2019
This was referenced Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes some wordings in the generic component for listing pages and save modals (used in visualize, dashboard, maps, graph, discover):
Changed: Save as new (remove “a”)
Changed: Title: Remove period in title “A with …”
Description: Clicking Save overwrites the existing .
Button: Save
Changed: Button: Create (without new)
Changed: Delete 1 ? (removed selected)
Changed: Delete 2 ? (removed selected)
Small change along the same lines: Aria label of "Save as new" button in saved query management changed from
Save as a new saved querytoSave as new saved query