Pass alert id to the alert type executor#47379
Merged
mikecote merged 9 commits intoelastic:masterfrom Oct 8, 2019
Merged
Conversation
mikecote
added
review
Feature:Alerting
v8.0.0
release_note:skip
Contributor
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
bmcconaghy
approved these changes
Oct 7, 2019
Contributor
bmcconaghy
left a comment
bmcconaghy
left a comment
There was a problem hiding this comment.
Code LGTM, optional comment re: attribute name.
x-pack/legacy/plugins/alerting/server/lib/get_create_task_runner_function.ts
Outdated
Show resolved
Hide resolved
…na into alerting/alert-executor-id
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Oct 8, 2019
* Pass alert id to the alert type executor * Rename id to alertId * Rename id to alertId in actions plugin * Fix translation variables
mikecote
added a commit
that referenced
this pull request
Oct 8, 2019
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Oct 9, 2019
* Pass alert id to the alert type executor * Rename id to alertId * Rename id to alertId in actions plugin * Fix translation variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I'm passing the alert id in context to the alert type executor.
The executor parameter is
alertId. In order to be consistent, I also renamed in the actions pluginidtoactionId.