Skip to content

[7.x] [Console] Fix Safari layout issue (#47100) #47187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jloleysens merged 1 commit into from
Oct 3, 2019
Merged

[7.x] [Console] Fix Safari layout issue (#47100) #47187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/legacy/core_plugins/console/np_ready/public/application/containers/main/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import React, { useCallback, useRef, useState } from 'react';
import React, { useCallback, useState } from 'react';
import { debounce } from 'lodash';
import { EuiFlexGroup, EuiFlexItem } from '@elastic/eui';

Expand Down Expand Up @@ -52,8 +52,6 @@ export function Main() {
const [showSettings, setShowSettings] = useState(false);
const [showHelp, setShowHelp] = useState(false);

const containerRef = useRef<null | HTMLDivElement>(null);

const [firstPanelWidth, secondPanelWidth] = storage.get(StorageKeys.WIDTH, [
INITIAL_PANEL_WIDTH,
INITIAL_PANEL_WIDTH,
Expand All @@ -71,9 +69,9 @@ export function Main() {
};

return (
<div className="consoleContainer" style={{ height: '100%', width: '100%' }} ref={containerRef}>
<>
<EuiFlexGroup
style={{ height: '100%' }}
className="consoleContainer"
gutterSize="none"
direction="column"
responsive={false}
Expand Down Expand Up @@ -118,6 +116,6 @@ export function Main() {
{showSettings ? <Settings onClose={() => setShowSettings(false)} /> : null}

{showHelp ? <HelpPanel onClose={() => setShowHelp(false)} /> : null}
</div>
</>
);
}
3 changes: 2 additions & 1 deletion src/legacy/core_plugins/console/public/quarantined/_app.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// TODO: Move all of the styles here (should be modularised by, e.g., CSS-in-JS or CSS modules).
#consoleRoot {
height: 100%;
display: flex;
flex: 1 1 auto;
// Make sure the editor actions don't create scrollbars on this container
// SASSTODO: Uncomment when tooltips are EUI-ified (inside portals)
overflow: hidden;
Expand Down