Skip to content

[i18n] Update .i18nrc.json in template #47118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bamieh merged 2 commits into from
Oct 2, 2019
Merged

[i18n] Update .i18nrc.json in template #47118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f7601e
Update .i18nrc.json
Bamieh Oct 2, 2019
aa881f7
Update get_translations_path.js
Bamieh Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/kbn-plugin-generator/sao_template/template/.i18nrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{
"paths": {
"<%= camelCase(name) %>": "./"
}
},
"translations": [
"translations/zh-CN.json"
]
}
10 changes: 6 additions & 4 deletions src/legacy/server/i18n/get_translations_path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,12 @@ export async function getTranslationPaths({ cwd, glob }) {
try {
const content = await readFileAsync(entryFullPath, 'utf8');
const { translations } = JSON.parse(content);
translations.forEach(translation => {
const translationFullPath = resolve(pluginBasePath, translation);
translationPaths.push(translationFullPath);
});
if (translations && translations.length) {
translations.forEach(translation => {
const translationFullPath = resolve(pluginBasePath, translation);
translationPaths.push(translationFullPath);
});
}
} catch (err) {
throw new Error(`Failed to parse .i18nrc.json file at ${entryFullPath}`);
}
Expand Down