[Console] Fix Safari layout issue#47100
Merged
jloleysens merged 3 commits intoelastic:masterfrom Oct 2, 2019
Merged
Conversation
jloleysens
added
Feature:Console
Contributor
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
alisonelizabeth
approved these changes
Oct 2, 2019
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
@jloleysens tested locally on chrome and safari and fix looks good! I left a couple questions about the scss.
|
|
||
| return ( | ||
| <div className="consoleContainer" style={{ height: '100%', width: '100%' }} ref={containerRef}> | ||
| <> |
Contributor
There was a problem hiding this comment.
I wasn't aware of this shorter syntax for fragments 👍
snide
suggested changes
Oct 2, 2019
Contributor
Author
|
Thanks for the review! I wasn't aware of the auto-prefixer in Kibana. I removed the vendor prefixes. |
Contributor
💚 Build Succeeded |
snide
approved these changes
Oct 2, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 3, 2019
* Remove 100% height, migrate console root to display flex * Remove unused import * Removed vendor prefixes in CSS
jloleysens
added a commit
that referenced
this pull request
Oct 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this Safari issue: #47076
The general strategy is to move away from using
heigh: 100%and instead use display flex for controlling height of the console app's root element. Because the root element is rendered through angular the styles applied to a flex group element have been copied to that class.Checklist