Skip to content

[Maps] More compressed forms#47043

Merged
elizabetdev merged 16 commits intoelastic:masterfrom
cchaos:maps-more-compressed-fb
Oct 2, 2019
Merged

[Maps] More compressed forms#47043
elizabetdev merged 16 commits intoelastic:masterfrom
cchaos:maps-more-compressed-fb

Conversation

@cchaos
Copy link
Contributor

@cchaos cchaos commented Oct 1, 2019

Layer Settings

Screen Shot 2019-10-01 at 11 22 03 AM

Source Settings

image

Vector styles

image

Question

I have hard-coded the px to the range labels. However, it seems it would be better to add another item to the shapes that controls the unit like:

export const staticSizeShape = PropTypes.shape({
  size: PropTypes.number.isRequired,
  unit: PropTypes.string,
});

When I tried this, however, it got really complicated. Mainly the question is, will it always be in pixels and therefore the hardcoded labels are ok, or can a dev help us expand these shapes?

Go To and Draw popovers

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@cchaos cchaos added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.5.0 labels Oct 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@cchaos cchaos added the release_note:skip Skip the PR/issue when compiling release notes label Oct 1, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@cchaos cchaos marked this pull request as ready for review October 1, 2019 21:17
@cchaos cchaos requested a review from a team as a code owner October 1, 2019 21:17
@cchaos cchaos requested a review from a team October 1, 2019 21:18
@cchaos cchaos force-pushed the maps-more-compressed-fb branch from 5be8483 to ca7031e Compare October 1, 2019 21:18
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese
Copy link
Contributor

nreese commented Oct 2, 2019

will it always be in pixels and therefore the hardcoded labels are ok, or can a dev help us expand these shapes?

Pixels should be fine. We can always refactor if that changes in the future

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Really like the labels to the left of the inputs and the condensed range sliders

lgtm
code review, tested in chrome

@snide
Copy link
Contributor

snide commented Oct 2, 2019

@nreese Did you mean to mark that as approved? If so I'll just go ahead and merge/backport this since caroline is now on vacation.

@elizabetdev elizabetdev requested a review from nreese October 2, 2019 13:35
@elizabetdev elizabetdev merged commit 68f20dc into elastic:master Oct 2, 2019
@snide snide deleted the maps-more-compressed-fb branch October 2, 2019 13:40
elizabetdev pushed a commit to elizabetdev/kibana that referenced this pull request Oct 2, 2019
* Adjusting vector size selectors

* Degrees

* Button group for symbol type

* i18n and snaps

* Input with popoper and icons

* Improving layer settings styles

* Column layout

* Changing step

* Fixed up the Go To and Draw popovers

* Removing unecessary css

* Improving source settings styles

* Improving design to avoid panel inside panel

* Remove unused translations

* Update x-pack/legacy/plugins/maps/public/components/metrics_editor.js

Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update x-pack/legacy/plugins/maps/public/components/_index.scss

Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Oh snap
snide pushed a commit that referenced this pull request Oct 2, 2019
* Adjusting vector size selectors

* Degrees

* Button group for symbol type

* i18n and snaps

* Input with popoper and icons

* Improving layer settings styles

* Column layout

* Changing step

* Fixed up the Go To and Draw popovers

* Removing unecessary css

* Improving source settings styles

* Improving design to avoid panel inside panel

* Remove unused translations

* Update x-pack/legacy/plugins/maps/public/components/metrics_editor.js

Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Update x-pack/legacy/plugins/maps/public/components/_index.scss

Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>

* Oh snap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants