[Maps] More compressed forms#47043
Merged
elizabetdev merged 16 commits intoelastic:masterfrom Oct 2, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
5be8483 to
ca7031e
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Pixels should be fine. We can always refactor if that changes in the future |
nreese
reviewed
Oct 2, 2019
Contributor
nreese
left a comment
There was a problem hiding this comment.
Looks great. Really like the labels to the left of the inputs and the condensed range sliders
lgtm
code review, tested in chrome
Contributor
|
@nreese Did you mean to mark that as approved? If so I'll just go ahead and merge/backport this since caroline is now on vacation. |
snide
approved these changes
Oct 2, 2019
elizabetdev
pushed a commit
to elizabetdev/kibana
that referenced
this pull request
Oct 2, 2019
* Adjusting vector size selectors * Degrees * Button group for symbol type * i18n and snaps * Input with popoper and icons * Improving layer settings styles * Column layout * Changing step * Fixed up the Go To and Draw popovers * Removing unecessary css * Improving source settings styles * Improving design to avoid panel inside panel * Remove unused translations * Update x-pack/legacy/plugins/maps/public/components/metrics_editor.js Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update x-pack/legacy/plugins/maps/public/components/_index.scss Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * Oh snap
snide
pushed a commit
that referenced
this pull request
Oct 2, 2019
* Adjusting vector size selectors * Degrees * Button group for symbol type * i18n and snaps * Input with popoper and icons * Improving layer settings styles * Column layout * Changing step * Fixed up the Go To and Draw popovers * Removing unecessary css * Improving source settings styles * Improving design to avoid panel inside panel * Remove unused translations * Update x-pack/legacy/plugins/maps/public/components/metrics_editor.js Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * Update x-pack/legacy/plugins/maps/public/components/_index.scss Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> * Oh snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer Settings
Source Settings
Vector styles
Question
I have hard-coded the
pxto the range labels. However, it seems it would be better to add another item to the shapes that controls theunitlike:When I tried this, however, it got really complicated. Mainly the question is, will it always be in pixels and therefore the hardcoded labels are ok, or can a dev help us expand these shapes?
Go To and Draw popovers
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility