[SR] render alert icon in policy table if last snapshot failed#46960
Merged
alisonelizabeth merged 3 commits intoelastic:masterfrom Oct 2, 2019
Merged
Conversation
alisonelizabeth
added
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui |
alisonelizabeth
added
the
release_note:skip
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
sebelga
approved these changes
Oct 2, 2019
Contributor
sebelga
left a comment
sebelga
left a comment
There was a problem hiding this comment.
LGTM! It seems that there is an empty css entry.
| */ | ||
| .snapshotRestorePolicyTableSnapshotFailureContainer { | ||
| max-width: 200px; | ||
| > .euiFlexItem:first-child { |
Contributor
There was a problem hiding this comment.
Do we need this empty selector?
Contributor
Author
There was a problem hiding this comment.
oops, forgot to remove that. thanks for the catch!
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an alert icon next to the snapshot name of a policy, if the last snapshot failed. This is determined by comparing the timestamps of the last failed snapshot and last successful snapshot.
Fixes #46795