Merged
Conversation
darnautov
added
release_note:enhancement
:ml
Feature:Anomaly Detection
Contributor
|
Pinging @elastic/ml-ui |
Contributor
Author
|
@elasticmachine merge upstream |
pheyos
reviewed
Sep 30, 2019
x-pack/legacy/plugins/ml/public/jobs/new_job/wizard/steps/job_type/job_type.html
Show resolved
Hide resolved
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
walterra
approved these changes
Oct 1, 2019
x-pack/legacy/plugins/ml/public/components/create_job_link_card/create_job_link_card.tsx
Outdated
Show resolved
Hide resolved
...legacy/plugins/ml/public/jobs/new_job/wizard/steps/job_type/__tests__/job_type_controller.js
Show resolved
Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/job_type/page.tsx
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
|
The style of the card for the recognized module in the data visualizer actions panel needs adjusting:
|
Contributor
|
When selecting a non-time based index pattern, the font of the text in the top callout looks a bit small compared to how it used to look. Before: After: Also, the link to the Data Visualizer should remain enabled for a non time-based index pattern: |
Contributor
|
Also I see issues on IE11, where the last card isn't rendering correctly - on the main Job Type page, and in the data visualizer actions panel:
|
jgowdyelastic
approved these changes
Oct 1, 2019
Member
jgowdyelastic
left a comment
jgowdyelastic
left a comment
There was a problem hiding this comment.
code generally LGTM, i added a suggestion about removing an any type
Contributor
💚 Build Succeeded |
peteharverson
approved these changes
Oct 2, 2019
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest changes, including on IE11, and all LGTM
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 2, 2019
* [ML] wip job types to react * [ML] delete angular job_type page * [ML] TS refactoring * [ML] restrict page width * [ML] refactor with CreateJobLinkCard * [ML] data-test-subj for functional tests * [ML] fix recognized results * [ML] missing i18n * [ML] add custom logo support for create job link card, change data recognizer layout * [ML] rename iconType prop * [ML] remove unused styles * [ML] fix page background * [ML] data recognizer wrappers * [ML] fix IE issue, IndexPatternSavedObject * [ML] fix callout * [ML] job type directive test * [ML] fix types
darnautov
added a commit
that referenced
this pull request
Oct 2, 2019
* [ML] wip job types to react * [ML] delete angular job_type page * [ML] TS refactoring * [ML] restrict page width * [ML] refactor with CreateJobLinkCard * [ML] data-test-subj for functional tests * [ML] fix recognized results * [ML] missing i18n * [ML] add custom logo support for create job link card, change data recognizer layout * [ML] rename iconType prop * [ML] remove unused styles * [ML] fix page background * [ML] data recognizer wrappers * [ML] fix IE issue, IndexPatternSavedObject * [ML] fix callout * [ML] job type directive test * [ML] fix types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #18374. Migrate Select job type for Create Job Wizard to React.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorialsFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately