Skip to content

[ML] Add clone tests for single metric, multi metric and population jobs #46894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pheyos merged 14 commits into from
Sep 30, 2019
Merged

[ML] Add clone tests for single metric, multi metric and population jobs #46894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7f1cee9
Add clone single metric job test
pheyos Sep 19, 2019
d28d240
Enable job creation again
pheyos Sep 19, 2019
5642439
Add clone single metric job test
pheyos Sep 19, 2019
f8cffdb
Enable job creation again
pheyos Sep 19, 2019
5e8cecc
Merge branch 'clone_single_metric_job' of https://github.com/pheyos/k…
pheyos Sep 23, 2019
8fd5752
Fix data-test-subj attributes and check run in realtime button after …
pheyos Sep 23, 2019
2d555e2
Refactor job wizard service actions to contain validations
pheyos Sep 23, 2019
7460ee0
Add model plot check and clean up debug code
pheyos Sep 26, 2019
950d5f8
Add clone steps to multi metric job test
pheyos Sep 27, 2019
ce84aef
Add clone steps to population job test
pheyos Sep 27, 2019
bfe3629
Merge branch 'master' into clone_job_tests
pheyos Sep 27, 2019
5856e35
Rename test files, small fixes
pheyos Sep 27, 2019
b4567be
Merge branch 'master' into clone_job_tests
pheyos Sep 30, 2019
c3ef36f
Address review comments
pheyos Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../ml/public/jobs/new_job_new/pages/components/charts/event_rate_chart/event_rate_chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ export const EventRateChart: FC<Props> = ({
loading = false,
}) => {
return (
<div style={{ width, height }} data-test-subj="mlEventRateChart">
<div
style={{ width, height }}
data-test-subj={`mlEventRateChart ${eventRateChartData.length ? 'withData' : 'empty'}`}
>
<LoadingWrapper height={height} hasData={eventRateChartData.length > 0} loading={loading}>
<Chart>
{showAxis === true && <Axes />}
Expand Down
4 changes: 2 additions & 2 deletions ..._job_new/pages/components/summary_step/components/post_save_options/post_save_options.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const PostSaveOptions: FC<Props> = ({ jobRunner }) => {
datafeedState === DATAFEED_STATE.STARTING || datafeedState === DATAFEED_STATE.STARTED
}
onClick={startJobInRealTime}
data-test-subj="mlButtonUseFullData3"
data-test-subj="mlJobWizardButtonRunInRealTime"
>
<FormattedMessage
id="xpack.ml.newJob.wizard.summaryStep.postSaveOptions.startJobInRealTime"
Expand All @@ -95,7 +95,7 @@ export const PostSaveOptions: FC<Props> = ({ jobRunner }) => {
watchCreated === true
}
onClick={() => setWatchFlyoutVisible(true)}
data-test-subj="mlButtonUseFullData"
data-test-subj="mlJobWizardButtonCreateWatch"
>
<FormattedMessage
id="xpack.ml.newJob.wizard.summaryStep.postSaveOptions.createWatch"
Expand Down
2 changes: 1 addition & 1 deletion ...plugins/ml/public/jobs/new_job_new/pages/components/time_range_step/time_range_picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const TimeRangePicker: FC<Props> = ({ setTimeRange, timeRange }) => {

return (
<Fragment>
<div style={{ minWidth: WIDTH }}>
<div style={{ minWidth: WIDTH }} data-test-subj={`jobWizardDateRange`}>
Copy link
Contributor

@walterra walterra Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see most data-test-subj have a ml prefix but this one does not - should we generally have it?

Copy link
Member Author

@pheyos pheyos Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. When I started creating test subjects, I've named them ml* with a rather long descriptive name, but over time I began to give shorter names to make parent-child relations better to read, e.g. testSubjects.getVisibleText(`dataSplit > splitCard front > splitCardTitle`). I'm still not perfectly sure what the best way of naming is, but ml namespacing is probably a good idea, so I will go through our test subjects in a follow-up and add it where needed.

Copy link
Member Author

@pheyos pheyos Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #47032

<EuiDatePickerRange
fullWidth={true}
startDateControl={
Expand Down
2 changes: 1 addition & 1 deletion x-pack/legacy/plugins/ml/public/jobs/new_job_new/pages/new_job/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const Page: FC<PageProps> = ({ existingJobsAndGroups, jobType }) => {

return (
<Fragment>
<EuiPage style={{ backgroundColor: 'inherit' }} data-test-subj="mlPageJobWizard">
<EuiPage style={{ backgroundColor: 'inherit' }} data-test-subj={`mlPageJobWizard ${jobType}`}>
<EuiPageBody>
<EuiPageContentBody>
<Wizard
Expand Down
213 changes: 0 additions & 213 deletions x-pack/test/functional/apps/machine_learning/create_multi_metric_job.ts
View file
Open in desktop

This file was deleted.

Loading