Create a pre wired version of SearchBar by lizozom · Pull Request #46702 · elastic/kibana

lizozom · 2019-09-26T13:34:20Z

Summary

Pass NP data plugin into data shim, to gain access to autocomplete
Added ui to DataStart to host stateful components
Added createSearchBar function to create a stateful SearchBar
Introduced SearchBarInjectedDeps and SearchBarOwnProps for createSearchBar
Update data shim tests to have a single function wrapping elements in Context.
- QueryBarInput
- QueryBarTopRow
- SearchBar
Remove npStart dependency from QueryBarInput by using autocomplete provided by KibanaContextProvider @alexwizp
Remove omit from render as it wasn't adding any attributes.
Use stateful SearchBar in TopNavMenu and remove injected state from kbn_top_nav.
Add KibanaContextProvider to vis_type_timeseries, vis/editors, graph, maps and lens

Checklist

Dev Docs

In order to use any of our stateful components, you are going to have to wrap your application on the topmost level with a KibanaContextProvider:

Assuming new platform syntax:

          <KibanaContextProvider
            services={{
              uiSettings: core.uiSettings,
              docLinks: core.docLinks,
              data: plugins.data,
            }}
          >
            {content}
          </KibanaContextProvider>

Then, inside a react component, you may use our stateful component, that requires less input and confuguration:

   const {
     ui: { SearchBar },
   } = plugins.data;

   render() {
      return <SearchBar
          appName="myApp"
          ...
        />
   }

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Pass storage and autocomplete to createSearchBar method Add appName and autocomplete to IDataPluginServices QueryBarInput to consume autocomplete and appName from context QueryBarTopRow to consume appName from context Remove appName from SearchBar Added AutocompletePublicPluginSetup and AutocompletePublicPluginStart types

elasticmachine · 2019-09-26T14:50:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-26T16:06:46Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…plugin/stateful-search-bar-2

elasticmachine · 2019-09-26T17:12:08Z

Pinging @elastic/kibana-app-arch

elasticmachine · 2019-09-26T17:35:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-26T17:35:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-26T18:41:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

TinaHeiligers · 2019-09-27T16:27:18Z

@Bargs you might also be interested in this PR

…plugin/stateful-search-bar-2

elasticmachine · 2019-09-29T13:09:47Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lizozom · 2019-09-29T13:28:15Z

retest

streamich

LGTM

src/legacy/core_plugins/data/public/plugin.ts

src/legacy/core_plugins/data/public/query/query_bar/components/query_bar_input.tsx

src/legacy/core_plugins/data/public/search/search_bar/components/bind_search_bar.tsx

TinaHeiligers

Looks ok to me once ci passes

…plugin/stateful-search-bar-2

elasticmachine · 2019-10-02T11:37:45Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

flash1293

Graph changes look good to me

elasticmachine · 2019-10-02T13:07:11Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Bind search bar * create prewired data components * Pass NP data plugin to shim plugin, to access autocomplete Pass storage and autocomplete to createSearchBar method Add appName and autocomplete to IDataPluginServices QueryBarInput to consume autocomplete and appName from context QueryBarTopRow to consume appName from context Remove appName from SearchBar Added AutocompletePublicPluginSetup and AutocompletePublicPluginStart types * Use KibanaContextProvider in vis editor and graph * Use KibanaContextProvider in maps * Use prewirted SearchBar in TopNavMenu * Use KibanaContextProbider in Lens * Fix appName usage in query bar input * fixed query bar top row appName * update tests * fixed bind search bar bug * mock SearchBar * Removed unnecessary mocks * Delete unused mock * Fixed exporting of data plugin types * Updated maps snapshot * Fixed some TS issues * Fixed jest tests * Context adjustments in TSVB * componentWillMount * Code review fixes * Pass dataTestSubj to query bar input * Graph data

rayafratkina · 2019-11-13T21:46:54Z

@lizozom can you please add a DevDocs section?

elasticmachine · 2019-11-14T18:32:59Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: cc39f89

Liza K added 7 commits September 26, 2019 14:31

Bind search bar

e22d673

create prewired data components

0c7eebf

Use KibanaContextProvider in vis editor and graph

c4525e9

Use KibanaContextProvider in maps

995bfeb

Use prewirted SearchBar in TopNavMenu

1d09108

Use KibanaContextProbider in Lens

08fed2f

lizozom self-assigned this Sep 26, 2019

Liza K added 5 commits September 26, 2019 16:36

Fix appName usage in query bar input

b4ce1f2

fixed query bar top row appName

7e2740c

update tests

35d365e

fixed bind search bar bug

4dd148d

mock SearchBar

4913548

Liza K added 2 commits September 26, 2019 17:54

Removed unnecessary mocks

c836679

Delete unused mock

65b592e

Liza K added 4 commits September 26, 2019 19:08

Fixed exporting of data plugin types

8dbf164

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

b4a80f6

…plugin/stateful-search-bar-2

Updated maps snapshot

1f84606

Fixed some TS issues

0f60094

lizozom changed the title ~~Newplatform/data plugin/stateful search bar 2~~ Create a pre wired version of SearchBar Sep 26, 2019

lizozom mentioned this pull request Sep 26, 2019

[lens] Use top nav in Lens app #46190

Merged

lizozom marked this pull request as ready for review September 26, 2019 17:11

lizozom requested a review from a team September 26, 2019 17:11

lizozom requested a review from a team as a code owner September 26, 2019 17:11

lizozom added Feature:NP Migration release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.5.0 v8.0.0 labels Sep 26, 2019

lizozom added the Team:AppArch label Sep 26, 2019

TinaHeiligers self-requested a review September 27, 2019 16:27

Liza K added 4 commits September 29, 2019 13:11

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

b7935cd

…plugin/stateful-search-bar-2

Fixed jest tests

64b9ec6

Context adjustments in TSVB

1fe975c

componentWillMount

23ae2e7

streamich approved these changes Sep 30, 2019

View reviewed changes

TinaHeiligers approved these changes Sep 30, 2019

View reviewed changes

Liza K added 3 commits October 2, 2019 10:20

Merge remote-tracking branch 'upstream/master' into newplatform/data-…

2eb5425

…plugin/stateful-search-bar-2

Code review fixes

0ca40af

Pass dataTestSubj to query bar input

eaac39c

Graph data

cc39f89

flash1293 self-requested a review October 2, 2019 12:10

flash1293 approved these changes Oct 2, 2019

View reviewed changes

lizozom merged commit 0cd9d6c into elastic:master Oct 2, 2019

lizozom mentioned this pull request Oct 2, 2019

[7.x] Create a pre wired version of SearchBar (#46702) #47115

Merged

lizozom deleted the newplatform/data-plugin/stateful-search-bar-2 branch November 14, 2019 13:03

Conversation

lizozom commented Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Dev Docs

For maintainers

Uh oh!

elasticmachine commented Sep 26, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 26, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 26, 2019

Uh oh!

elasticmachine commented Sep 26, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 26, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 26, 2019

💔 Build Failed

Uh oh!

TinaHeiligers commented Sep 27, 2019

Uh oh!

elasticmachine commented Sep 29, 2019

💔 Build Failed

Uh oh!

lizozom commented Sep 29, 2019

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 2, 2019

💚 Build Succeeded

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 2, 2019

💚 Build Succeeded

Uh oh!

rayafratkina commented Nov 13, 2019

Uh oh!

elasticmachine commented Nov 14, 2019

💔 Build Failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lizozom commented Sep 26, 2019 •

edited

Loading