[Discover] De-angularize side bar search field by kertal · Pull Request #46679 · elastic/kibana

kertal · 2019-09-26T08:24:35Z

Summary

De-angularize and adapt new design for Discover's field search.

Aside the search/filter by name, additional fields for filtering can be displayed. Note that they are not part of the PR (still angular), will be targeted soon.

One difference to the original behavior is that the filtering/searching also takes place in selected fields.

Additional filter fields folded:

Additional fields unfolded:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~- [ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

~~- [ ] This was checked for breaking API changes and was labeled appropriately~~

This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-26T11:24:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…-23-discover-field-filter

elasticmachine · 2019-09-26T16:10:54Z

Pinging @elastic/kibana-app

src/legacy/core_plugins/kibana/public/discover/components/field_chooser/_field_chooser.scss

elasticmachine · 2019-09-26T17:35:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

ryankeairns

Great start! It looks like the Lens stuff is moving along, so we can steal from them soon to improve this further :)

elasticmachine · 2019-09-26T18:40:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-27T07:02:08Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-27T16:32:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

kertal · 2019-09-30T06:27:02Z

@elasticmachine merge upstream

elasticmachine · 2019-09-30T07:34:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

flash1293

Tested in chrome and works, LGTM 👍

One thing I noticed (not a blocker for this PR): Currently _source is implicitly selected if nothing else is selected. Somehow (this is probably a separate bug) it is counted as a missing field and thus not shown in the selected list from now on (even if it's there and shown in the table). It might make sense to show _source as the initial selected field when Discover is opened, just to be consistent with what is shown in the table and in the side bar.

...egacy/core_plugins/kibana/public/discover/components/field_chooser/discover_field_search.tsx

.../core_plugins/kibana/public/discover/components/field_chooser/discover_field_search.test.tsx

flash1293 · 2019-09-30T08:22:09Z

...egacy/core_plugins/kibana/public/discover/components/field_chooser/discover_field_search.tsx

+      <EuiFlexItem grow={false}>
+        <EuiButtonIcon
+          aria-expanded={showFilter}
+          aria-label={filterBtnAriaLabel}


IMHO it would be nice to also have this in a tooltip - what do you think?

👍 will do!

…om:kertal/kibana into kertal-pr-2019-09-23-discover-field-filter

kertal · 2019-09-30T14:49:11Z

Tested in chrome and works, LGTM 👍

One thing I noticed (not a blocker for this PR): Currently _source is implicitly selected if nothing else is selected. Somehow (this is probably a separate bug) it is counted as a missing field and thus not shown in the selected list from now on (even if it's there and shown in the table). It might make sense to show _source as the initial selected field when Discover is opened, just to be consistent with what is shown in the table and in the side bar.

good catch, thx! now _source works like before!

elasticmachine · 2019-09-30T15:50:53Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

- due to padding issues collapsing didn't work

elasticmachine · 2019-10-01T18:59:30Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…-23-discover-field-filter

… btn - this caused the functional test to fail

elasticmachine · 2019-10-02T08:02:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

* Add DiscoverFieldSearch react component * Adapt field_chooser.js * Add jest test * Adapt scss

kertal added 8 commits September 25, 2019 21:56

Add DiscoverFieldSearch react component

6dc76b0

Adapt field_chooser.js

268929f

Add DiscoverFieldSearch react component

dee9147

Adapt component and usage

00fe05f

Add jest test

492b7a3

Adapt scss

e3b7807

Migrate from EuiButtonToggle to EuiButtonIcon

b10bf05

Remove unused translations

f60176b

kertal self-assigned this Sep 26, 2019

kertal mentioned this pull request Sep 26, 2019

[discover] De-angularize index pattern selection #46347

Merged

5 tasks

kertal added 2 commits September 26, 2019 17:48

Merge remote-tracking branch 'upstream/master' into kertal-pr-2019-09…

6bd3bf5

…-23-discover-field-filter

Change filter icon + height for alignment

9c3baad

kertal added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Sep 26, 2019

kertal added release_note:enhancement v7.5.0 labels Sep 26, 2019

kertal requested review from flash1293, mdefazio and ryankeairns September 26, 2019 16:11

ryankeairns reviewed Sep 26, 2019

View reviewed changes

src/legacy/core_plugins/kibana/public/discover/components/field_chooser/_field_chooser.scss Outdated Show resolved Hide resolved

Use CSS BEM naming scheme for toggleFieldFilterButton

aac51b1

kertal requested a review from ryankeairns September 26, 2019 17:19

ryankeairns approved these changes Sep 26, 2019

View reviewed changes

kertal marked this pull request as ready for review September 27, 2019 05:32

kertal requested a review from a team as a code owner September 27, 2019 05:32

Adapt reactDirective

836aa3d

merge upstream/master

9825fde

Merge branch 'master' into kertal-pr-2019-09-23-discover-field-filter

50826c7

kertal added v8.0.0 Feature:Discover Discover Application labels Sep 30, 2019

flash1293 approved these changes Sep 30, 2019

View reviewed changes

kertal added 2 commits September 30, 2019 16:35

Various adaptions

a45ac05

Merge branch 'kertal-pr-2019-09-23-discover-field-filter' of github.c…

478daee

…om:kertal/kibana into kertal-pr-2019-09-23-discover-field-filter

Fix CSS issue when sidebar is collapsed

890d107

- due to padding issues collapsing didn't work

kertal added 2 commits October 2, 2019 07:50

Merge remote-tracking branch 'upstream/master' into kertal-pr-2019-09…

8113c83

…-23-discover-field-filter

Change position of the tooltip showing when hovering the toggle field…

aa8e021

… btn - this caused the functional test to fail

kertal merged commit 03ccb43 into elastic:master Oct 2, 2019

kertal deleted the kertal-pr-2019-09-23-discover-field-filter branch October 2, 2019 08:11

kertal added a commit to kertal/kibana that referenced this pull request Oct 2, 2019

[Discover] De-angularize side bar search field (elastic#46679)

2d0f7b2

* Add DiscoverFieldSearch react component * Adapt field_chooser.js * Add jest test * Adapt scss

kertal mentioned this pull request Oct 2, 2019

[7.x] [Discover] De-angularize side bar search field (#46679) #47097

Merged

kertal added a commit that referenced this pull request Oct 2, 2019

[Discover] De-angularize side bar search field (#46679) (#47097)

2e0acef

* Add DiscoverFieldSearch react component * Adapt field_chooser.js * Add jest test * Adapt scss

Conversation

kertal commented Sep 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 26, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 26, 2019

Uh oh!

Uh oh!

elasticmachine commented Sep 26, 2019

💔 Build Failed

Uh oh!

ryankeairns left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 26, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 27, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 27, 2019

💚 Build Succeeded

Uh oh!

kertal commented Sep 30, 2019

Uh oh!

elasticmachine commented Sep 30, 2019

💚 Build Succeeded

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

flash1293 Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

kertal Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

kertal Sep 30, 2019

Choose a reason for hiding this comment

Uh oh!

kertal commented Sep 30, 2019

Uh oh!

elasticmachine commented Sep 30, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 1, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Oct 2, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kertal commented Sep 26, 2019 •

edited

Loading