Closed
Conversation
Contributor
|
Pinging @elastic/code |
Contributor
💔 Build Failed |
Contributor
|
A couple of follow up steps per offline discussion:
Regarding questions:
I would suggest keep it simple first and add it later in case we need them.
At least for the first iteration, this is not necessary. We can add it if it's required next.
yes |
I want to build this off of a general RepoSelector component, that allows one to select or import a new repo to Code. When selected, a callback is invoked with some Code-specific arguments.
Since the value will not have changed on blur, onChange has exactly the same effect, here.
We're going to need this on both the projects page and now the RepoSelectorComponent.
* All the actions are stubbed * It needs style * There are questions about data sources and persistence
Adds copy and some basic CSS.
There's still a gap here because this is Code's data, not APM's data, but this is a little closer to what we'll have in the end.
onImportSuccess will be invoked with the imported repo's URI when the import has succeeded. That's the idea, at least.
Contributor
💔 Build Failed |
7 tasks
Contributor
Author
|
Closing in favor of #47180 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a basic proof of concept for elastic/code#1637. It is meant to be a general-purpose component for integrations with Code. It performs the following duties:
Data and actions are both stubbed.
Questions this has surfaced:
https://github.com/rylnd/dotfiles) sufficient for the Code side of the Code/Service mapping in APM?