[Lens] Add IP support to Lens #46383
Conversation
chrisdavies
added
v8.0.0
release_note:skip
💚 Build Succeeded |
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Code LGTM, didn't test locally
| const icons: Partial<Record<string, UnwrapArray<typeof ICON_TYPES>>> = { | ||
| boolean: 'invert', | ||
| date: 'calendar', | ||
| ip: 'compute', |
There was a problem hiding this comment.
There was a problem hiding this comment.
I definitely don't think it should be link. We use that more exclusively for actual URL's. compute sort of works, but I worry that it's only recognizable by those with more intimate knowledge of computer parts. I'd lean towards online because it's indicating there's an internet connection. Or if that really doesn't work, maybe storage, otherwise we'd have to create something new.
There was a problem hiding this comment.
+1 for a specific "IP" icon. I like storage second best till that's ready.
There was a problem hiding this comment.
note that with #46485 discover will use the same icons (for now in black, but coloring is already built in), there are a few more here, but I think it would make sense to have 1 shared component just for this icons. A specific IP icon would be welcome, but also the storage one is fine
| return Boolean( | ||
| newField && | ||
| newField.type === 'string' && | ||
| supportedTypes.has(newField.type) && |
There was a problem hiding this comment.
oops, thanks for taking care of that.
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
💚 Build Succeeded |
5 participants
Adds support for IP fields to the Lens editor.