[APM] Add API test for agent configuration#46003
[APM] Add API test for agent configuration#46003sorenlouv wants to merge 1 commit intoelastic:7.4from
Conversation
sorenlouv
added
release_note:skip
There was a problem hiding this comment.
This makes the output much cleaner. Instead of outputting Expected {...hugeObject} to have property statusCode 404 it will now output Expected 500 to be 404
There was a problem hiding this comment.
Added support for specifying method and body
|
Pinging @elastic/apm-ui |
There was a problem hiding this comment.
Destructuring instead of positional arguments (the third argument is optional)
There was a problem hiding this comment.
Removed some excessive line spacing
💔 Build Failed |
dgieselaar
left a comment
dgieselaar
left a comment
There was a problem hiding this comment.
LGTM. I think we can also remove expectForbidden/expectResponse because it's all 404/200 now, but maybe out of scope for this PR.
|
@elasticmachine merge upstream |
💔 Build Failed |
|
@elasticmachine merge upstream |
💔 Build Failed |
sorenlouv
force-pushed
the
apm-add-api-test
branch
from
93b8834 to
e7f3fe5
Compare
sorenlouv
force-pushed
the
apm-add-api-test
branch
from
e7f3fe5 to
ad61ad6
Compare
💔 Build Failed |
|
Closed in favor of #46316 |
3 participants
Adding a test for agent configuration to avoid regressions like #45903
I also cleaned the test up a little.