[7.x] [Code] New SearchPage layout (#45821)#45975
Merged
rylnd merged 1 commit intoelastic:7.xfrom Sep 19, 2019
Merged
Conversation
Contributor
Author
|
@mw-ding this diff is larger than the corresponding 7.4 backport, seemingly because #45822 was 'ported to 7.4 but not 7.x. I see no reason that those translations shouldn't be added to 7.x, but I'll admit that I'm still learning the release process, so I'd appreciate your feedback here. |
Contributor
|
hmm. this is weird. the Japanese i18n items are there for |
Contributor
💚 Build Succeeded |
* Remove now-unused ScopeTabs component The new layout does not include these tabs; their utility is redundant with the ScopeSelector dropdown in the search bar. * Remove unused style Randomly found this orphaned rule while in here. The consuming component was deleted in a previous commit (ef8d7ea). * Use consistent block names in our BEM classes Others in this component already use codeQueryBar, so... * Move the Search bar above both the sidebar and main content * Align the search dropdown's RHS with the search sidebar This required a little coordination between the two components through a couple of sass variables. * Remove erroneous width rule This was incorrect for two reasons: * You need to interpolate the sass variable within calc * This is the same as width: auto and can be deleted * Copy: Search Filter -> Advanced Filter Also removes some odd spacing surrounding the text; that should be done with CSS instead. * Space out badge with margin, not nbsp The copy previously had a leading space; using margin is a better approach. The class that was replaced was unused. * Fix alignment of Filters flyout badge This tweaks the pink badge to be aligned with the text on the flyout title. Also removes a now-obsolete className (code-flyout-title). * Adjust layout of Search filter sidebar * Indents facets below the filter's title * Adjusts spacing to be more consistent, removes use of EuiSpacer NB there's a bit of a hack for the indentation itself: we use an empty, fixed-width div for the facet's icon prop. * Fix newline errors These were introduced by some default vscode settings, which have now been resolved. * Update snapshots following markup changes * Less hacky way of indenting facet buttons Rather than use an empty, fixed-width div as an icon, just give it some margin-left. * Swap hardcoded rem values for equivalent eui vars * One more eui var replacement * Remove unused import * Remove unused translations These existed in the ScopeTabs component which has been deleted.
rylnd
force-pushed
the
backport/7.x/pr-45821
branch
from
5749ce3 to
642d03f
Compare
Contributor
Author
|
retest |
mw-ding
approved these changes
Sep 18, 2019
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: