bable does not fully support subclassing Array#4571
Merged
colings86 merged 4 commits intoelastic:masterfrom Aug 4, 2015
Merged
bable does not fully support subclassing Array#4571colings86 merged 4 commits intoelastic:masterfrom
colings86 merged 4 commits intoelastic:masterfrom
Conversation
spalger
changed the title
colings86
added a commit
that referenced
this pull request
Aug 4, 2015
bable does not fully support subclassing Array
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Aug 4, 2015
albanm
pushed a commit
to MGDIS/kibana
that referenced
this pull request
Aug 19, 2015
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Aug 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4561
iojs supports subclassing
Arrayto some degree, and when serializing theUiAppsclass was responding with a simple JSON array. Bable does not have the same behavior and serialized the class as an object.