Respect xpack.monitoring.show_license_expiration#45537
Merged
cachedout merged 1 commit intoelastic:masterfrom Sep 13, 2019
Merged
Respect xpack.monitoring.show_license_expiration#45537cachedout merged 1 commit intoelastic:masterfrom
cachedout merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Nice find! It looks like I was the offender in this PR: #27253 so it seems this has been broken for awhile now. |
chrisronline
approved these changes
Sep 12, 2019
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
LGTM! (Pending CI passing)
Contributor
💚 Build Succeeded |
Contributor
|
Also, I think we need to add more labels: |
cachedout
added a commit
to cachedout/kibana
that referenced
this pull request
Sep 17, 2019
7 tasks
cachedout
added a commit
that referenced
this pull request
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #43691
We weren't looking at the config setting for
xpack.monitoring.show_license_expirationwhen rendering the Overview page.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.~~
This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers