fix navbar color customization#4548
Merged
spalger merged 4 commits intoelastic:masterfrom Aug 5, 2015
Merged
Conversation
Contributor
Author
|
@spalger it's still accessing Maybe that's another change to put in this PR? |
Contributor
|
I would appreciate it if you added it to this pull. Would you also look at other properties? |
Contributor
Author
|
@spalger Added get/set Visible controls and moved the logo stuff to the Brand get/set. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom navbar style was not being applied since it was setting
internalbut the markup was reading fromchrome.Made the markup use
chome.getNavBackground(), with great success!