[ML] Fixing empty time range when cloning jobs #45286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
alvarezmelissa87,
darnautov,
peteharverson and
walterra
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💔 Build Failed |
Contributor
|
Please merge master |
jgowdyelastic
force-pushed
the
fixing-empty-time-range-when-cloning-jobs
branch
from
d60cd38 to
538efcc
Compare
Contributor
💚 Build Succeeded |
peteharverson
approved these changes
Sep 11, 2019
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested and confirmed time range is now retained when cloning a job in the wizards. LGTM
darnautov
approved these changes
Sep 11, 2019
x-pack/legacy/plugins/ml/public/jobs/new_job_new/common/job_creator/util/general.ts
Outdated
Show resolved
Hide resolved
jgowdyelastic
force-pushed
the
fixing-empty-time-range-when-cloning-jobs
branch
from
4ef9930 to
a8b102b
Compare
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 11, 2019
* [ML] Fixing empty time range when cloning jobs * removing if statement
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Sep 11, 2019
* [ML] Fixing empty time range when cloning jobs * removing if statement
jgowdyelastic
added a commit
that referenced
this pull request
Sep 11, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Sep 11, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (25 commits) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) disable jest suite that has no enabled tests (elastic#44250) disable flaky test (elastic#45317) disable flaky test (elastic#45315) [DOCS] Creates developer folder (elastic#45280) [SIEM] Changes ML conditional links to use tabs, fixes a small bug with null filterQuery (elastic#45218) ...
Contributor
alvarezmelissa87
left a comment
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Bit late but LGTM ⚡️ 😄
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 11, 2019
…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
startandendproperties to thetempJobCloningObjectsobject to allow the time range step to be auto populated then cloning a job, converting a single to multi-metric job or reseting a job.When cloning a job from the jobs list, the
earliest_record_timestampandlatest_record_timestampvalues for the job are used.Also switches off model plot when converting a single to multi metric job.
cc: @pheyos
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately