Rename QueryBar to QueryBarTopRow

[lizozom]

Summary

Rename QueryBar to QueryBarTopRow and make it an implementation detail of the query service.

Dev Docs

• Rename QueryBar to QueryBarTopRow
• Stop exporting QueryBar on the public contract.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-arch

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[Bargs]

The SearchBar component is intended to work anywhere, not just the global top row necessarily, so I wouldn't recommend referencing TopRow in the QueryBar component's name.

[lizozom]

@Bargs QueryBar is a sub-component of SearchBar, which is never used externally.
Applications would either consume SearchBar as a whole or QueryBarInput if they want just the input component.

You can see that I didn't only rename the component, but I also stopped exporting it from the plugin's API, so it can't be used by anyone outside the plugin.

Does this make it clearer?

[ppisljar]

LGTM

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[Bargs]

@lizozom Why include TopRow in the name though? TopRow makes me think it's referring to the fact that it is usually in the TopNav. Does TopRow just refer to the fact that it is in the first row of the SearchBar? Why include the position in the name at all?

[ppisljar]

we are renaming it as we want to rename searchbar to querybar later.
so if i understand correctly, querybartoprow is not part of our contract, its internal implenentation of querybar (currently known as searchbar) ... i am guessing that its the top part of the query bar (the current search bar).

as its not something we would expose on our contracts i really think we shoulnt loose any time on naming discussions here

[lizozom]

retest

[lizozom]

retest

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[lizozom]

@Bargs as @ppisljar said, we are making this component internal, so I just renamed it to something easy and specific, to free up the name QueryBar as we're going to need it later, to rename SearchBar.

I would appreciate your approval.

[Bargs]

as its not something we would expose on our contracts i really think we shoulnt loose any time on naming discussions here

This wasn't a silly naming discussion, I kept asking because the name made no sense to me whatsoever and no one was answering my relatively simple question about what the name actually meant. I want to ensure there is not a misunderstanding about where and how the SearchBar component is meant to be used.

i am guessing that its the top part of the query bar (the current search bar).

If this guess is correct (please confirm @lizozom) then that's fine with me.

[lizozom]

@Bargs QueryBar is the top row of the search bar - a wrapper around LanguageSwitcher, 'QueryInputBar', EuiSuperTimepicker and EuiRefreshButton.

As you (correctly) moved the logic to SearchBar, were removing QueryBar from the contract.

Agreed in thread