Fix highlighting when no field is specified#4519
Merged
w33ble merged 3 commits intoelastic:masterfrom Aug 4, 2015
Merged
Conversation
Contributor
|
Submitted lukasolson#6 which merged master |
Contributor
|
Nice find. LGTM! |
w33ble
added a commit
that referenced
this pull request
Aug 4, 2015
Fix highlighting when no field is specified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4494.
With the upgrade to ES 2.0, there were some changes to highlighting, namely the default setting for
require_field_match.From the 1.6 documentation:
require_field_matchcan be set totruewhich will cause a field to be highlighted only if a query matched that field.falsemeans that terms are highlighted on all requested fields regardless if the query matches specifically on them.From the 2.0 documentation:
require_field_matchcan be set tofalsewhich will cause any field to be highlighted regardless of whether the query matched specifically on them. The default behaviour istrue, meaning that only fields that hold a query match will be highlighted.