Skip to content

Compile query validation tooltip once #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w33ble merged 1 commit into from
Jul 13, 2015
Merged

Compile query validation tooltip once #4413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/kibana/components/validate_query/validate_query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ define(function (require) {
// track request so we can abort it if needed
var request = {};

var errorElem = $('<i class="fa fa-ban input-error"></i>').hide();
var errorElem = $('<i tooltip={{tooltipMsg}} class="fa fa-ban input-error"></i>').hide();
$compile(errorElem)($scope);

var init = function () {
elem.after(errorElem);
Expand Down Expand Up @@ -84,10 +85,7 @@ define(function (require) {
msg = resp.body.error;
}

errorElem.attr('tooltip', msg);

// Compile is needed for the tooltip
$compile(errorElem)($scope);
$scope.tooltipMsg = msg;
errorElem.show();

return undefined;
Expand Down