[NP] Timelion by gospodarsky · Pull Request #44039 · elastic/kibana

gospodarsky · 2019-08-26T20:59:16Z

Summary

Related to #31968

Shim Timelion plugin to NP.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-08-26T22:27:27Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…form

elasticmachine · 2019-08-28T11:38:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/legacy/core_plugins/timelion/index.ts

src/legacy/core_plugins/timelion/public/panels/timechart/timechart.js

src/legacy/plugin_discovery/types.ts

src/legacy/core_plugins/timelion/public/plugin.ts

elasticmachine · 2019-08-28T13:34:02Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

spalger · 2019-08-28T21:35:25Z

retest

elasticmachine · 2019-08-28T22:58:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

lukeelmers

Overall no major concerns, though I still need to test this locally. Added a couple notes

src/legacy/core_plugins/timelion/public/plugin.ts

src/legacy/core_plugins/timelion/public/panels/timechart/timechart.js

…form

elasticmachine · 2019-09-24T13:11:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/legacy/plugin_discovery/types.ts

src/legacy/core_plugins/timelion/public/plugin.ts

src/legacy/core_plugins/timelion/public/panels/timechart/schema.ts

elasticmachine · 2019-09-24T14:53:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

alexwizp

LGTM, don't have any objections now =). thanks

elasticmachine · 2019-09-24T16:15:21Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-24T16:52:48Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-24T17:44:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…form

elasticmachine · 2019-09-25T10:23:38Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

see comments above

src/legacy/core_plugins/timelion/public/shim/legacy_dependencies_plugin.ts

src/legacy/core_plugins/timelion/public/vis/index.ts

src/legacy/core_plugins/timelion/public/vis/timelion_request_handler.ts

src/legacy/core_plugins/timelion/public/plugin.ts

src/legacy/core_plugins/timelion/public/legacy.ts

src/legacy/core_plugins/timelion/public/directives/chart/chart.js

…form

elasticmachine · 2019-09-26T11:30:21Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

LGTM

* Move index.js to index.ts * Migrate Vis, interpreter, home and 2 hacks to setup() and start() * Move Timechart hack to start() * Add featureCatalogueRegistryProvider to an interface * Add types to a server param * Move some .js to .ts * Add ExpressionFunction<> to interpreter * Remove Feature Provider * Remove extra export * Add an interface to a timelion response * Add an inteface to the panel * Add IPrivate interface * Make nit notes * Edit uiCapabilities() type * Shim Timelion plugin * Shim start() plugin method * Change InternalCoreStart to LegacyCoreStart * Move Angular dependencies to a separate module * Change visualizations import path due to recent changes * Rename directives * Take a common property out * Get rid of require in schema * Use core.uiSettings * Refactor timelion request handler * Remove Private from tests * Remove redundant dependencies from tests * Update visualizations paths * Change expressions paths due to expessions movement * Refactoring according to reviews * Add a comment over the uiCapabilities field * Edit the comment * Ignore uiCapabilities issue * Take angular controller out * Get rid of * Get rid of config * Get rid of config in start * Unwrap handler from redundant promise * Move npSetup npStart dependencies in a high level * Rename some details * Fix reviews * fix CI * Take visFactory out

Move index.js to index.ts

6a249bf

gospodarsky added the Feature:New Platform label Aug 26, 2019

gospodarsky self-assigned this Aug 26, 2019

gospodarsky added the WIP Work in progress label Aug 26, 2019

gospodarsky requested a review from alexwizp August 26, 2019 20:59

art.gospodarsky added 5 commits August 27, 2019 17:58

Merge remote-tracking branch 'upstream/master' into timelion-new-plat…

f8d6c16

…form

Merge remote-tracking branch 'upstream/master' into timelion-new-plat…

ce99228

…form

Merge remote-tracking branch 'upstream/master' into timelion-new-plat…

c11faa4

…form

Migrate Vis, interpreter, home and 2 hacks to setup() and start()

a8bde3e

Move Timechart hack to start()

69887c7

gospodarsky added the release_note:enhancement label Aug 28, 2019

Add featureCatalogueRegistryProvider to an interface

ca5bcc9

gospodarsky changed the title ~~[WIP] [NP] Timelion~~ [NP] Timelion Aug 28, 2019

gospodarsky removed the WIP Work in progress label Aug 28, 2019

alexwizp reviewed Aug 28, 2019

View reviewed changes

src/legacy/core_plugins/timelion/index.ts Outdated Show resolved Hide resolved

alexwizp reviewed Aug 28, 2019

View reviewed changes

src/legacy/core_plugins/timelion/public/panels/timechart/timechart.js Outdated Show resolved Hide resolved

alexwizp reviewed Aug 28, 2019

View reviewed changes

src/legacy/plugin_discovery/types.ts Outdated Show resolved Hide resolved

alexwizp reviewed Aug 28, 2019

View reviewed changes

src/legacy/core_plugins/timelion/public/plugin.ts Outdated Show resolved Hide resolved

gospodarsky requested review from lukeelmers, markov00, ppisljar, streamich and timroes August 28, 2019 15:35

Add types to a server param

446b96c

lukeelmers reviewed Aug 29, 2019

View reviewed changes

src/legacy/core_plugins/timelion/public/plugin.ts Outdated Show resolved Hide resolved

src/legacy/core_plugins/timelion/public/panels/timechart/timechart.js Outdated Show resolved Hide resolved

gospodarsky requested a review from ppisljar September 23, 2019 18:55

Artyom Gospodarsky added 3 commits September 24, 2019 13:17

Merge remote-tracking branch 'upstream/master' into timelion-new-plat…

feed318

…form

Unwrap handler from redundant promise

7b4b104

Move npSetup npStart dependencies in a high level

68ae787

gospodarsky requested a review from alexwizp September 24, 2019 13:11

Rename some details

bb3ec7a

alexwizp reviewed Sep 24, 2019

View reviewed changes

src/legacy/plugin_discovery/types.ts Outdated Show resolved Hide resolved

alexwizp reviewed Sep 24, 2019

View reviewed changes

src/legacy/core_plugins/timelion/public/plugin.ts Show resolved Hide resolved

alexwizp reviewed Sep 24, 2019

View reviewed changes

src/legacy/core_plugins/timelion/public/panels/timechart/schema.ts Show resolved Hide resolved

Fix reviews

9708804

gospodarsky requested a review from alexwizp September 24, 2019 15:03

fix CI

dff86b3

alexwizp approved these changes Sep 24, 2019

View reviewed changes

Merge remote-tracking branch 'upstream/master' into timelion-new-plat…

f37d54c

…form

ppisljar requested changes Sep 25, 2019

View reviewed changes

Artyom Gospodarsky added 2 commits September 26, 2019 11:38

Merge remote-tracking branch 'upstream/master' into timelion-new-plat…

68f7127

…form

Take visFactory out

bb28ce8

gospodarsky requested a review from ppisljar September 26, 2019 11:00

ppisljar approved these changes Sep 26, 2019

View reviewed changes

gospodarsky merged commit 237ad82 into elastic:master Sep 26, 2019

This was referenced Sep 27, 2019

[7.x] [NP] Timelion (#44039) #46766

Merged

Refactor panelRegistry in Timelion plugin #46770

Closed

Conversation

gospodarsky commented Aug 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Aug 26, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Aug 28, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Aug 28, 2019

💚 Build Succeeded

Uh oh!

spalger commented Aug 28, 2019

Uh oh!

elasticmachine commented Aug 28, 2019

💚 Build Succeeded

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Sep 24, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Sep 24, 2019

💔 Build Failed

Uh oh!

alexwizp left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 24, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 24, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 24, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 25, 2019

💚 Build Succeeded

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Sep 26, 2019

💚 Build Succeeded

Uh oh!

ppisljar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gospodarsky commented Aug 26, 2019 •

edited

Loading