Skip to content

[7.x] [code] Add option to turn the go dependency download on/off. (#43096)#43165

Merged
movie-travel-code merged 1 commit intoelastic:7.xfrom
movie-travel-code:backport/7.x/pr-43096
Aug 13, 2019
Merged

[7.x] [code] Add option to turn the go dependency download on/off. (#43096)#43165
movie-travel-code merged 1 commit intoelastic:7.xfrom
movie-travel-code:backport/7.x/pr-43096

Conversation

@movie-travel-code
Copy link

Backports the following commits to 7.x:

…#43096)

There are no proper approaches to disable downloading go dependencies
except creating inconsistencies of the running environments of
go-langserver. Given that go language server will do its best to convert
the repos into modules, one of the doable approaches is setting
'GO111MODULE' to false to be incompatible with the moduled repos.
@movie-travel-code movie-travel-code added the backport This PR is a backport of another PR label Aug 13, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@movie-travel-code movie-travel-code merged commit 212e185 into elastic:7.x Aug 13, 2019
@movie-travel-code movie-travel-code deleted the backport/7.x/pr-43096 branch August 13, 2019 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants