[7.x] [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (#40650)#42977
Merged
andrewvc merged 5 commits intoelastic:7.xfrom Sep 4, 2019
Merged
[7.x] [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (#40650)#42977andrewvc merged 5 commits intoelastic:7.xfrom
andrewvc merged 5 commits intoelastic:7.xfrom
Conversation
…astic#40650) I had previously revised these tests to utilize Jest's toBeCloseTo assertion, because it provides a precision parameter. My understanding when I implemented this test was that it would check n significant digits, so if I ran code like expect(myValue).toBeCloseTo(36000, 3), a value like 36015 would be accepted by the assertion. After seeing this test fail in a flaky way while testing other changes (it failed when myValue === 36001), I researched the function more closely and found that it does not behave this way. This led me to opt for the current solution, which should help avoid any flakiness issues while continuing to rely on the end-user simplicity of a snapshot. I do not expect a variance greater than 1 when running these tests, so the threshold of 100 should be sufficient to consider these tests stable.
andrewvc
added
backport
Contributor
|
Pinging @elastic/uptime |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, retest this please |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, retest this please |
Contributor
💚 Build Succeeded |
Contributor
|
@andrewvc it looks like we're passing CI but you should perform a rebase against |
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, retest this please |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Member
|
@elasticmachine, run elasticsearch-ci/docs |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: