Add request flyout to Remote Clusters.#42900
Merged
cjcenizal merged 4 commits intoelastic:masterfrom Aug 13, 2019
Merged
Conversation
cjcenizal
added
enhancement
cjcenizal
added
release_note:enhancement
and removed
enhancement
cjcenizal
force-pushed
the
remote-clusters-show-request
branch
from
9c71f51 to
9fbb81f
Compare
cjcenizal
force-pushed
the
remote-clusters-show-request
branch
from
9fbb81f to
dfbed3b
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jen-huang
approved these changes
Aug 12, 2019
| const request = `${endpoint}\n${payload}`; | ||
|
|
||
| return ( | ||
| <EuiPortal> |
Contributor
There was a problem hiding this comment.
is EuiPortal need for flyouts?
| {name ? ( | ||
| <FormattedMessage | ||
| id="xpack.remoteClusters.requestFlyout.namedTitle" | ||
| defaultMessage="Request for {name}" |
Contributor
There was a problem hiding this comment.
can we do Request for '{name}' (name in single quotes)? we do this in other areas where the object name is part of a phrase
| id="xpack.remoteClusters.remoteClusterForm.saveButtonLabel" | ||
| defaultMessage="Save" | ||
| id="xpack.remoteClusters.remoteClusterForm.toggleRequestButtonLabel" | ||
| defaultMessage="Show request" |
Contributor
There was a problem hiding this comment.
should this text change based on if the flyout is open or not? I think it'll be hidden in most cases when the flyout is open, but I can see it on my wide monitor:
| {request} | ||
| </EuiCodeBlock> | ||
| </EuiFlyoutBody> | ||
| </EuiFlyout> |
Contributor
There was a problem hiding this comment.
can we add a EuiFlyoutFooter that contains a close button so the user doesn't have to target the small close icon?
- Remove unnecessary EuiPortal. - Wrap name in quotes. - Change button text to show/hide based on state. - Add flyout footer with close button.
Contributor
💚 Build Succeeded |
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 13, 2019
cjcenizal
added a commit
that referenced
this pull request
Aug 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42793
Release note
This is a minor enhancement to display the underlying Elasticsearch endpoint in the "Add Remote Cluster" form. Users can copy and paste this endpoint and payload to execute the request manually or use it within a script or other automated system.