Show endpoint in JSON preview of index lifecycle policy editor. #42791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce tabs from 4 to 2. - Increase flyout width to 480px and remove overlay. - Show line numbers.
cjcenizal
added
release_note:enhancement
Feature:ILM
v8.0.0
Team:Kibana Management
Contributor
|
Pinging @elastic/es-ui |
This was referenced Aug 6, 2019
Contributor
💚 Build Succeeded |
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
@cjcenizal thanks for adding this!
I think the copyToClipboard method will need to be updated as well to include the endpoint. I noticed when I click the copy button it only copies the json. Can you take a look?
Contributor
Author
|
Great catch about the clipboard behavior, will fix! Thanks. |
…tle and endpoint when there is no name specified.
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@alisonelizabeth Ready for another review! |
alisonelizabeth
approved these changes
Aug 7, 2019
Contributor
alisonelizabeth
left a comment
alisonelizabeth
left a comment
There was a problem hiding this comment.
@cjcenizal tested locally and works great now. Thanks!
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 7, 2019
…tic#42791) * Reduce tabs from 4 to 2. * Increase flyout width to 480px and remove overlay. * Show line numbers. * Use EuiCopy component. * Add description text. * Update title and endpoint when there is no name specified.
cjcenizal
added a commit
that referenced
this pull request
Aug 8, 2019
…) (#42896) * Reduce tabs from 4 to 2. * Increase flyout width to 480px and remove overlay. * Show line numbers. * Use EuiCopy component. * Add description text. * Update title and endpoint when there is no name specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
Note that the endpoint is rendered only if the user has defined a policy name.
Release note
This is a minor enhancement to display the underlying Elasticsearch endpoint in the Index Lifecycle editor. Users can copy and paste this endpoint and payload to execute the request manually or use it within a script or other automated system.