Skip to content

Add SSL support when starting Elasticsearch from yarn es#42527

Merged
mikecote merged 10 commits intoelastic:masterfrom
mikecote:kbn-es/ssl-support
Aug 7, 2019
Merged

Add SSL support when starting Elasticsearch from yarn es#42527
mikecote merged 10 commits intoelastic:masterfrom
mikecote:kbn-es/ssl-support

Conversation

@mikecote
Copy link
Contributor

@mikecote mikecote commented Aug 2, 2019

In this PR, I'm adding --ssl support to yarn es ... commands. This will setup Elasticsearch with SSL enabled including the proper certificates it needs.

Changes include:

  • Make kbn-es support ssl
  • Making Cluster constructor take an object of options instead of log.
  • Add ssl option to Cluster constructor
  • Add fixed certificates to re-use

@mikecote mikecote added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 2, 2019
@mikecote mikecote self-assigned this Aug 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@elasticmachine

This comment has been minimized.

@mikecote mikecote marked this pull request as ready for review August 2, 2019 16:52
@mikecote mikecote added the review label Aug 2, 2019
@mikecote mikecote requested a review from a team August 2, 2019 16:53
@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple nits

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mikecote mikecote merged commit aaea567 into elastic:master Aug 7, 2019
mikecote added a commit to mikecote/kibana that referenced this pull request Aug 7, 2019
…2527)

* Initial work

* Add integration tests

* Use constants

* Fix broken code

* Handle scenario where esArgs is a string

* Remove || []

* Apply PR feedback

* Use const format
mikecote added a commit that referenced this pull request Aug 7, 2019
…42839)

* Initial work

* Add integration tests

* Use constants

* Fix broken code

* Handle scenario where esArgs is a string

* Remove || []

* Apply PR feedback

* Use const format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Kibana-Operations Team v7.4.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants