Skip to content

[ML] [Job wizards] switching to new kibana context provider#42512

Merged
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:switching-to-new-kibana-context-providers
Aug 2, 2019
Merged

[ML] [Job wizards] switching to new kibana context provider#42512
jgowdyelastic merged 1 commit intoelastic:masterfrom
jgowdyelastic:switching-to-new-kibana-context-providers

Conversation

@jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 2, 2019

Now using kibanaContext as introduced in #42244

@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 2, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 2, 2019 09:01
@jgowdyelastic jgowdyelastic self-assigned this Aug 2, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 2, 2019

Pinging @elastic/ml-ui

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 2, 2019

💔 Build Failed

@timroes
Copy link
Contributor

timroes commented Aug 2, 2019 •
edited
Loading

Jenkins, test this - a potential flaky but unrelated @elastic/kibana-gis test already failed. I aborted the job so we don't need to wait for the full build to fail before retest

peteharverson
peteharverson approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Aug 2, 2019

retest

@elasticmachine
Copy link
Contributor

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit a42c12d into elastic:master Aug 2, 2019
@jgowdyelastic jgowdyelastic deleted the switching-to-new-kibana-context-providers branch August 2, 2019 10:48
@jgowdyelastic
Copy link
Member Author

jgowdyelastic commented Aug 2, 2019

backport waiting on #42288.

alvarezmelissa87
alvarezmelissa87 reviewed Aug 2, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

walterra pushed a commit to walterra/kibana that referenced this pull request Aug 5, 2019
@jgowdyelastic @walterra
[ML] [Job wizards] switching to new kibana context provider (elastic#…
9ea8471 
…42512)
@walterra walterra mentioned this pull request Aug 5, 2019
Merged
walterra added a commit that referenced this pull request Aug 6, 2019
@walterra
[7.x] [ML] Use context and custom hooks to manage legacy dependencies. (
7a1348f 
#42244) (#42572)

* [ML] Use context and custom hooks to manage legacy dependencies. (#42244)
* [ML] [Job wizards] switching to new kibana context provider (#42512)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 left review comments

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels

:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.4.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jgowdyelastic @elasticmachine @timroes @walterra @alvarezmelissa87 @peteharverson