Skip to content

[WIP] Mappings editor#42453

Closed
sebelga wants to merge 40 commits intoelastic:masterfrom
sebelga:feature/mappings-editor-schema-definitions-2
Closed

[WIP] Mappings editor#42453
sebelga wants to merge 40 commits intoelastic:masterfrom
sebelga:feature/mappings-editor-schema-definitions-2

Conversation

@sebelga
Copy link
Contributor

@sebelga sebelga commented Aug 1, 2019

This is a draft of the mappings editor form.

@cjcenizal @yaronp68 I updated the screenshots with the "edit" capability. I will ask the UI team for some mock up of the advanced settings.

Note: this is all mock data, badges are probably all wrong 😊

Screen Shot 2019-08-07 at 13 50 20

Screen Shot 2019-08-07 at 13 50 40

Screen Shot 2019-08-07 at 13 51 06

In the below screenshot we can see the problem to display validation messages.

Screen Shot 2019-08-07 at 13 51 45

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sebelga sebelga force-pushed the feature/mappings-editor-schema-definitions-2 branch from e793bb7 to 03d1307 Compare August 2, 2019 10:07
@elasticmachine
Copy link
Contributor

💔 Build Failed

@yaronp68
Copy link

yaronp68 commented Aug 7, 2019

@sebelga great work. I would suggest that the save will be at the bottom right of the form so user don't need to move the mouse or lose sight when tabbing next (as the button is above his eyes focus). Instead of save should be "Done" because the user is done editing this field but not really saving the work in Elasticsearch. The send form button should be renamed to Save or OK in order to submit the form and create the mappings

@sebelga
Copy link
Contributor Author

sebelga commented Aug 8, 2019

@yaronp68 For the button position, by putting it on the top right, there is a link with the property item being edited, or when adding a property, to the object where the new property will be added.
I will let you play with it on the branch to get a feel of it.

@sebelga
Copy link
Contributor Author

sebelga commented Aug 9, 2019

@yaron @cjcenizal the PR branch is updated with all the changes we discussed. I also committed the form lib to be reverted later.

This branch is not yet for code review. I will go back to the code and clean it up a bit.
But this PR is for

  • testing functionality (UX)
  • detect possible bugs
  • Have a live version for the EUI team to improve on the advanced settings form

Cheers!

@elasticmachine
Copy link
Contributor

💔 Build Failed

@yaronp68
Copy link

yaronp68 commented Aug 9, 2019

love the latest changes to UX. Should we add tooltips to the action icons?

@cjcenizal
Copy link
Contributor

Had a couple thoughts:

  1. I found the alphabetically-reordering a bit jarring because as soon as I create a new field at the bottom of the mappings, it "disappears" when it's moved to the top. I think we could improve this UX by performing the reordering when first loading a mapping to be edited, but not performing any live reordering as the user is making changes.
  2. We might want to put this off until later, but I think a "Clone field" functionality could be useful if there are many fields that are similar but have slight differences. We might want to validate this with users/SEs/PMs.

@sebelga
Copy link
Contributor Author

sebelga commented Aug 19, 2019

Thanks for the feedback @yaronp68 and @cjcenizal
For the tooltip, yes we will need to add one. For the re-ordering, let see if others feel the same pain (I didn't so far). If we go the way you describe @cjcenizal , we might want to add a button to sort them manually as I do see value to easily find a field alphabetically.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@sebelga
Copy link
Contributor Author

sebelga commented Oct 22, 2019

I am closing this PR in favor of the feature branch one #47562

@sebelga sebelga closed this Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants