Conversation
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
e793bb7 to
03d1307
Compare
💔 Build Failed |
|
@sebelga great work. I would suggest that the save will be at the bottom right of the form so user don't need to move the mouse or lose sight when tabbing next (as the button is above his eyes focus). Instead of save should be "Done" because the user is done editing this field but not really saving the work in Elasticsearch. The send form button should be renamed to Save or OK in order to submit the form and create the mappings |
|
@yaronp68 For the button position, by putting it on the top right, there is a link with the property item being edited, or when adding a property, to the object where the new property will be added. |
|
@yaron @cjcenizal the PR branch is updated with all the changes we discussed. I also committed the form lib to be reverted later. This branch is not yet for code review. I will go back to the code and clean it up a bit.
Cheers! |
💔 Build Failed |
|
love the latest changes to UX. Should we add tooltips to the action icons? |
|
Had a couple thoughts:
|
|
Thanks for the feedback @yaronp68 and @cjcenizal |
…editor-schema-definitions-2
This reverts commit 9befa25.
💔 Build Failed |
…editor-schema-definitions-2
…editor-schema-definitions-2
…editor-schema-definitions-2
💔 Build Failed |
|
I am closing this PR in favor of the feature branch one #47562 |
This is a draft of the mappings editor form.
@cjcenizal @yaronp68 I updated the screenshots with the "edit" capability. I will ask the UI team for some mock up of the advanced settings.
Note: this is all mock data, badges are probably all wrong 😊
In the below screenshot we can see the problem to display validation messages.