Skip to content

[ML] Merging job wizards feature branch to master#42339

Merged
jgowdyelastic merged 31 commits intomasterfrom
feature-new-ml-job-wizards-new
Jul 31, 2019
Merged

[ML] Merging job wizards feature branch to master#42339
jgowdyelastic merged 31 commits intomasterfrom
feature-new-ml-job-wizards-new

Conversation

@jgowdyelastic
Copy link
Member

Merging new job wizards feature branch to master

* [ML] Adding new job wizards services

* adding ts-ignore for incomplte kibana timefilter type
* [ML] New job wizards UI

* small refactor

* fixing type problems

* updating snapshots

* updating translations ids for temporary new job links

* updating translation ids

* fixing population by field selection

* small refactor to by field select

* moving component descriptions to separate files

* moving chart grid component into own file

* fixing event rate count detector

* fixing decimal place rounding

* changes based on review

* more changes based on review

* fixing test
* [ML] Adding job json preview

* fix typo
* [ML] Adding generic custom settings functions to job creator

* fixing typo
* [ML] Adding advanced section to job details step

* disabling model plot for population

* changes based on review

* updating include paths
* [ML] Adding additional settings section to job details step

* changes based on review
* [ML] Adding basic job validation

* removing observable

* small refactor

* comments and refactors

* disabling create job button

* adding duplicate job and group id checks

* disabling next on invalid wizard step

* changes based on review

* removing unused includes
* [ML] Adding advanced job validation

* clean up

* function rename

* updating tests

* show some previous step info

* removing . from validation titles

* fixes advanced validation duration check

* removing include
* [ML] Changing wizard layout

* adding a comment

* fixing wizard step link issue

* removing greyed out controls in summary

* filtering out basic validation results

* adding wizards steps back into summary

* moving idFilterList

* removing unused includes
* [ML] Adding date picker to time range step

* adding comments

* sorting influencers

* removing euiSize for width
* [ML] Displaying job creation errors

* removing unnecessary try/catch
* [ML] Updating index pattern type

* changes based on review
@jgowdyelastic jgowdyelastic added review non-issue Indicates to automation that a pull request should not appear in the release notes :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Jul 31, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner July 31, 2019 11:52
@jgowdyelastic jgowdyelastic self-assigned this Jul 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Jul 31, 2019
@jgowdyelastic jgowdyelastic changed the title [ML] Feature new ml job wizards new [ML] Merging job wizards feature branch to master Jul 31, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jgowdyelastic
Copy link
Member Author

backport waiting on #42288

jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 5, 2019
* [ML] Adding new job wizards services (elastic#40718)

* [ML] Adding new job wizards services

* adding ts-ignore for incomplte kibana timefilter type

* [ML] New job wizards UI (elastic#40748)

* [ML] New job wizards UI

* small refactor

* fixing type problems

* updating snapshots

* updating translations ids for temporary new job links

* updating translation ids

* fixing population by field selection

* small refactor to by field select

* moving component descriptions to separate files

* moving chart grid component into own file

* fixing event rate count detector

* fixing decimal place rounding

* changes based on review

* more changes based on review

* fixing test

* [ML] Adding created_by to job (elastic#41015)

* [ML] Adding json preview (elastic#41078)

* [ML] Adding job json preview

* fix typo

* [ML] Fixing view results button (elastic#41077)

* [ML] Adding generic custom settings functions to job creator (elastic#41046)

* [ML] Adding generic custom settings functions to job creator

* fixing typo

* [ML] Adding advanced section to job details step (elastic#41157)

* [ML] Adding advanced section to job details step

* disabling model plot for population

* changes based on review

* updating include paths

* [ML] Adding additional settings section to job details step (elastic#41339)

* [ML] Adding additional settings section to job details step

* changes based on review

* [ML] Adding basic job validation (elastic#41459)

* [ML] Adding basic job validation

* removing observable

* small refactor

* comments and refactors

* disabling create job button

* adding duplicate job and group id checks

* disabling next on invalid wizard step

* changes based on review

* removing unused includes

* [ML] Adding advanced job validation (elastic#41634)

* [ML] Adding advanced job validation

* clean up

* function rename

* updating tests

* show some previous step info

* removing . from validation titles

* fixes advanced validation duration check

* removing include

* [ML] Changing wizard layout (elastic#41802)

* [ML] Changing wizard layout

* adding a comment

* fixing wizard step link issue

* removing greyed out controls in summary

* filtering out basic validation results

* adding wizards steps back into summary

* moving idFilterList

* removing unused includes

* [ML] Adding date picker to time range step (elastic#41978)

* [ML] Adding date picker to time range step

* adding comments

* sorting influencers

* removing euiSize for width

* [ML] Displaying job creation errors (elastic#42165)

* [ML] Displaying job creation errors

* removing unnecessary try/catch

* [ML] Updating index pattern type (elastic#42269)

* [ML] Updating index pattern type

* changes based on review
jgowdyelastic added a commit that referenced this pull request Aug 5, 2019
* [ML] Adding new job wizards services (#40718)

* [ML] Adding new job wizards services

* adding ts-ignore for incomplte kibana timefilter type

* [ML] New job wizards UI (#40748)

* [ML] New job wizards UI

* small refactor

* fixing type problems

* updating snapshots

* updating translations ids for temporary new job links

* updating translation ids

* fixing population by field selection

* small refactor to by field select

* moving component descriptions to separate files

* moving chart grid component into own file

* fixing event rate count detector

* fixing decimal place rounding

* changes based on review

* more changes based on review

* fixing test

* [ML] Adding created_by to job (#41015)

* [ML] Adding json preview (#41078)

* [ML] Adding job json preview

* fix typo

* [ML] Fixing view results button (#41077)

* [ML] Adding generic custom settings functions to job creator (#41046)

* [ML] Adding generic custom settings functions to job creator

* fixing typo

* [ML] Adding advanced section to job details step (#41157)

* [ML] Adding advanced section to job details step

* disabling model plot for population

* changes based on review

* updating include paths

* [ML] Adding additional settings section to job details step (#41339)

* [ML] Adding additional settings section to job details step

* changes based on review

* [ML] Adding basic job validation (#41459)

* [ML] Adding basic job validation

* removing observable

* small refactor

* comments and refactors

* disabling create job button

* adding duplicate job and group id checks

* disabling next on invalid wizard step

* changes based on review

* removing unused includes

* [ML] Adding advanced job validation (#41634)

* [ML] Adding advanced job validation

* clean up

* function rename

* updating tests

* show some previous step info

* removing . from validation titles

* fixes advanced validation duration check

* removing include

* [ML] Changing wizard layout (#41802)

* [ML] Changing wizard layout

* adding a comment

* fixing wizard step link issue

* removing greyed out controls in summary

* filtering out basic validation results

* adding wizards steps back into summary

* moving idFilterList

* removing unused includes

* [ML] Adding date picker to time range step (#41978)

* [ML] Adding date picker to time range step

* adding comments

* sorting influencers

* removing euiSize for width

* [ML] Displaying job creation errors (#42165)

* [ML] Displaying job creation errors

* removing unnecessary try/catch

* [ML] Updating index pattern type (#42269)

* [ML] Updating index pattern type

* changes based on review
@spalger spalger deleted the feature-new-ml-job-wizards-new branch November 8, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:enhancement review v7.4.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants