Skip to content

Disable request module's reset pollInterval test.#42259

Closed
cjcenizal wants to merge 1 commit intoelastic:masterfrom
cjcenizal:test/disable-request-poll-interval
Closed

Disable request module's reset pollInterval test.#42259
cjcenizal wants to merge 1 commit intoelastic:masterfrom
cjcenizal:test/disable-request-poll-interval

Conversation

@cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jul 30, 2019

Introduced by #40777. This was failing intermittently:

        AssertError: expected stub to be called twice but was called thrice
    stub(/success, {  }) => { data: { message: "Success message" }, statusCode: 200 } at Object.sendPost [as post] (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/linux-immutable/kibana/src/plugins/es_ui_shared/public/request/request.test.js:61:16)
    stub(/success, {  }) => { data: { message: "Success message" }, statusCode: 200 } at Object.sendPost [as post] (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/linux-immutable/kibana/src/plugins/es_ui_shared/public/request/request.test.js:61:16)
    stub(/success, {  }) => { data: { message: "Success message" }, statusCode: 200 } at Object.sendPost [as post] (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/linux-immutable/kibana/src/plugins/es_ui_shared/public/request/request.test.js:61:16)
    at Object.fail (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/linux-immutable/kibana/node_modules/sinon/lib/sinon/assert.js:106:21)
    at failAssertion (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/linux-immutable/kibana/node_modules/sinon/lib/sinon/assert.js:65:16)
    at Object.assert.(anonymous function) [as calledTwice] (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/linux-immutable/kibana/node_modules/sinon/lib/sinon/assert.js:91:13)
    at Object.calledTwice (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-intake/node/linux-immutable/kibana/src/plugins/es_ui_shared/public/request/request.test.js:235:24)

@cjcenizal cjcenizal added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Jul 30, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 30, 2019

Pinging @elastic/es-ui

@cjcenizal cjcenizal requested a review from timroes July 30, 2019 14:46
@cjcenizal cjcenizal force-pushed the test/disable-request-poll-interval branch from 089131f to 8e23d33 Compare July 30, 2019 14:47
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 30, 2019

💔 Build Failed

timroes
timroes approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Jul 30, 2019

Retest

@cjcenizal
Copy link
Contributor Author

cjcenizal commented Jul 30, 2019

This has already been skipped.

@cjcenizal cjcenizal closed this Jul 30, 2019
@cjcenizal cjcenizal deleted the test/disable-request-poll-interval branch July 30, 2019 17:54
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 30, 2019

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@timroes timroes timroes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.4.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cjcenizal @elasticmachine @timroes