Merged
Conversation
timroes
added
Feature:Query Bar
Contributor
|
Pinging @elastic/kibana-app |
Contributor
💚 Build Succeeded |
kertal
approved these changes
Jul 30, 2019
Member
kertal
left a comment
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, Tested in Chrome.
In case you want to be a busy 🐝 you could also adapt the filters applied text in the same file to sentence case
Contributor
Author
|
Good catch Matthias. I think that label is actually completely broken since it should contain the numbers of filters (broke in #40262). Will fix that. |
Contributor
💔 Build Failed |
Contributor
Author
|
Jenkins, test this - great CI passed but failed to report that correctly |
kertal
approved these changes
Jul 30, 2019
Contributor
💔 Build Failed |
Member
|
jenkins test this (quit playing games with tim's ❤️) |
Contributor
💚 Build Succeeded |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Jul 30, 2019
* Add missing i18n call * Fix filter applied message * Add another missing translation
timroes
pushed a commit
that referenced
this pull request
Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #42176
Adds the missing
i18n.translatecall (we try to get away from the React intl properties) for the "Filters" text in the query bar. It also fixes the "filter applied." message which broke in #40262.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately