[7.x] Extract useRequest and sendRequest from SR into es-ui-shared plugin (#40777)#42200
Merged
cjcenizal merged 1 commit intoelastic:7.xfrom Jul 29, 2019
Merged
Conversation
…lastic#40777) - Refactor SR's consumption to send UI metric telemetry in the promise chain, to uncouple the request functions from telemetry. - Refactor useRequest to return isInitialRequest instead of tracking polling state. - Rename request callback to sendRequest. - Rename loading flag to isLoading. - Rename changeInterval callback to setRequestInterval. - Rename interval parameter to pollIntervalMs. - Remove initialData from return value. - Preserve complete response shape instead of removing everything except the data property. - Send a request when path, body, or method changes. - Don't send a request when the interval changes. - Remove setRequestInterval from return value. - Expect the consumer to change the interval config in order to set it to a new value. - Refactor internals so that calling sendRequest resets the interval. - Migrate Watcher to use shared request library. - Rename onSuccess to deserializer and use it to process data. - Rename updateInterval function to scheduleRequest. - Don’t watch method parameter.
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: