[7.x] [Uptime] Improve useUrlParams hook for Uptime app (#41545)#41818
Merged
justinkambic merged 1 commit intoelastic:7.xfrom Jul 24, 2019
Merged
[7.x] [Uptime] Improve useUrlParams hook for Uptime app (#41545)#41818justinkambic merged 1 commit intoelastic:7.xfrom
useUrlParams hook for Uptime app (#41545)#41818justinkambic merged 1 commit intoelastic:7.xfrom
Conversation
justinkambic
added
release_note:enhancement
Team:Uptime - DEPRECATED
Contributor
|
Pinging @elastic/uptime |
Contributor
Author
|
jenkins test this |
* WIP moving things around. * Refactor useUrlParams hook and usages in Uptime app. * Add unit test for new url params hook. * Update test snapshots. * Resolving some issues. * Add ReactRouter objects to RefreshContext. * Update url helper and context to better handle cases, simplify hook. * Add tests for helper function. * Update url params hook unit tests. * Replace outdated snapshot.
justinkambic
force-pushed
the
backport/7.x/pr-41545
branch
from
35e3e99 to
24c4ca7
Compare
Contributor
💔 Build Failed |
Contributor
|
jenkins retest this please |
Contributor
💚 Build Succeeded |
7 tasks
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 24, 2019
* upstream/7.x: Ensure visualizations in percentage mode respect the advanced settings percent format (elastic#39044) (elastic#41855) [7.x] [telemetry] Analytics Package (elastic#41113) (elastic#41774) [Uptime] Improve `useUrlParams` hook for Uptime app (elastic#41545) (elastic#41818) [Maps] refactor filter actions to use embeddable actions (elastic#41713) (elastic#41821) [Maps] clean up tooltip header and footer (elastic#41793) (elastic#41816) [SIEM] Timeline NOT working with unauthorized (elastic#41767) (elastic#41873) Use index patterns service inside data plugin (rather than importing from ui/public) (elastic#41639) (elastic#41867)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x:
useUrlParamshook for Uptime app ([Uptime] ImproveuseUrlParamshook for Uptime app #41545)