[Maps][File upload] Set geojson indexed layer defaults for bounds and global #41789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
Team:Geo
Contributor
|
Pinging @elastic/kibana-gis |
kindsun
added
the
release_note:skip
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
…ery-defaults-geojson-upload
Contributor
💚 Build Succeeded |
…ery-defaults-geojson-upload
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
Nice little improvement, will avoid much grief. See comment.
x-pack/legacy/plugins/maps/public/layers/sources/client_file_source/constants.js
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
added 2 commits
July 29, 2019 15:10
…ery-defaults-geojson-upload
Contributor
💚 Build Succeeded |
thomasneirynck
approved these changes
Aug 1, 2019
Contributor
thomasneirynck
left a comment
thomasneirynck
left a comment
There was a problem hiding this comment.
lgtm on remerge with master and green CI
…ery-defaults-geojson-upload
Contributor
💚 Build Succeeded |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Aug 2, 2019
… global (elastic#41789) * Set 'map bounds' and 'global query' default to 'false' for indexed geojson layers * Add constants file * Clean up * Dynamically determine whether or not to filter by map bounds based upon docCount
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Aug 2, 2019
… global (elastic#41789) * Set 'map bounds' and 'global query' default to 'false' for indexed geojson layers * Add constants file * Clean up * Dynamically determine whether or not to filter by map bounds based upon docCount # Conflicts: # x-pack/legacy/plugins/maps/public/layers/sources/client_file_source/geojson_file_source.js # x-pack/legacy/plugins/maps/public/reducers/map.js
kindsun
pushed a commit
that referenced
this pull request
Aug 2, 2019
… global (#41789) (#42533) * Set 'map bounds' and 'global query' default to 'false' for indexed geojson layers * Add constants file * Clean up * Dynamically determine whether or not to filter by map bounds based upon docCount # Conflicts: # x-pack/legacy/plugins/maps/public/layers/sources/client_file_source/geojson_file_source.js # x-pack/legacy/plugins/maps/public/reducers/map.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #40082. Previously, indexed GeoJSON file layers defaulted to default values of
truefor layer properties:applyGlobalQueryandsourceDescriptor.filterByMapBounds. This sets these initial defaults tofalseas a safer option for widely varying data and data-size for files uploaded via the File Uploader.