Skip to content

[7.x] [Maps] Only color legend icon with dynamic color when dynamic config is complete (#41607) #41664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nreese merged 1 commit into from
Jul 22, 2019
Merged

[7.x] [Maps] Only color legend icon with dynamic color when dynamic config is complete (#41607) #41664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions x-pack/legacy/plugins/maps/public/layers/styles/components/vector/legend/vector_icon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@ function extractColorFromStyleProperty(colorStyleProperty, defaultColor) {
return colorStyleProperty.options.color;
}

// Do not use dynamic color unless configuration is complete
if (!colorStyleProperty.options.field || !colorStyleProperty.options.field.name) {
return defaultColor;
}

// return middle of gradient for dynamic style property
return getColorRampCenterColor(colorStyleProperty.options.color);
}
Expand Down
3 changes: 3 additions & 0 deletions x-pack/legacy/plugins/maps/public/layers/styles/components/vector/legend/vector_icon.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ const defaultProps = {
type: VectorStyle.STYLE_TYPE.DYNAMIC,
options: {
color: 'Blues',
field: {
name: 'prop1'
}
}
}
};
Expand Down