[7.x] [Reporting] Prettier up common/lib/screenshots and generate_pdf.js (#41488)#41542
Merged
tsullivan merged 4 commits intoelastic:7.xfrom Jul 24, 2019
Merged
[7.x] [Reporting] Prettier up common/lib/screenshots and generate_pdf.js (#41488)#41542tsullivan merged 4 commits intoelastic:7.xfrom
tsullivan merged 4 commits intoelastic:7.xfrom
Conversation
tsullivan
commented
Jul 19, 2019
| ({ browser, itemsCount }) => ({ browser, itemsCount }) | ||
| ), | ||
| tap(() => logger.debug('positioning elements')), | ||
| // Waiting till _after_ elements have rendered before injecting our CSS |
Member
Author
There was a problem hiding this comment.
This is adding a change from another PR which missed getting backported to 7.x: #31949 (comment)
tsullivan
commented
Jul 19, 2019
| return Rx.from(urls).pipe( | ||
| mergeMap(url => screenshotsObservable(url, conditionalHeaders, layout, browserTimezone), // eslint-disable-line no-unused-vars | ||
| (outer, inner) => inner, | ||
| mergeMap(url => screenshotsObservable(url, conditionalHeaders, layout, browserTimezone), |
Member
Author
There was a problem hiding this comment.
(outer, inner) => inner, being removed is from https://github.com/elastic/kibana/pull/40284/files#r305170223
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Member
Author
|
jenkins test this |
Member
|
retest |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: