-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Code] Use seq_no and primary_term to do ES concurrency control for EsQueue and reenable code tests #41377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/code |
Contributor
💔 Build Failed |
Contributor
Author
|
Confirmed that this change on ES's end has been merged these 2 days. A more formal discussion on this can be found here: elastic/elasticsearch#38254 |
Contributor
💚 Build Succeeded |
zfy0701
approved these changes
Jul 17, 2019
This was referenced Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The reason for the recent Code test failures is that ES snapshot now explicitly throws the following errors if querying ES with
versionfor concurrency control. The esqueue library lives inside code currently uses this stale way to do it. Updating toseq_noandprimary_termfixes the problem.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers